mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity
75,960 Commits 61 Branches 565 Tags 420 MiB
Commit Graph

57 Commits

Author SHA1 Message Date
Eugene Kenny ee525ff663 Load framework test files in deterministic order 
`Dir.glob` doesn't guarantee the order of its results:

https://ruby-doc.org/core-2.6.5/Dir.html#method-c-glob

> Case sensitivity depends on your system (File::FNM_CASEFOLD is
> ignored), as does the order in which the results are returned.

Minitest stores a list of all test cases in the order that they were
defined; it shuffles them before they're run, but doesn't sort them:

https://github.com/seattlerb/minitest/blob/v5.13.0/lib/minitest.rb#L1048
https://github.com/seattlerb/minitest/blob/v5.13.0/lib/minitest.rb#L156

This means that the order in which framework tests run is platform
dependent, and running a test command that failed in CI locally won't
necessarily reproduce the error, even when the same seed is provided.

`Rake::FileList` resolves glob patterns to a sorted list of files:

https://github.com/ruby/rake/blob/v13.0.1/lib/rake/file_list.rb#L408

By using `Rake::FileList` instead of `Dir.glob`, framework tests will
always run in the same order when given the same seed, and reproducing
order dependent CI failures will be easier.
 2019-12-16 16:55:06 +00:00
Kir Shatrov d7b1521db8 Use frozen string literal in activemodel/ 2017-07-16 20:11:16 +03:00
Matthew Draper 87b3e226d6 Revert "Merge pull request #29540 from kirs/rubocop-frozen-string" 
This reverts commit 3420a14590, reversing
changes made to afb66a5a59.
 2017-07-02 02:15:17 +09:30
Kir Shatrov cfade1ec7e Enforce frozen string in Rubocop 2017-07-01 02:11:03 +03:00
bogdanvlviv 40bdbce191
Define path with __dir__ 
".. with __dir__ we can restore order in the Universe." - by @fxn

Related to 5b8738c2df
 2017-05-23 00:53:51 +03:00
Xavier Noria bb1ecdcc67 fixes remaining RuboCop issues [Vipul A M, Xavier Noria] 2016-09-01 23:41:49 +02:00
Xavier Noria fa911a74e1 modernizes hash syntax in activemodel 2016-08-06 19:37:12 +02:00
Xavier Noria e6ab70c439 applies new string literal convention to the rest of the project 
The current code base is not uniform. After some discussion,
we have chosen to go with double quotes by default.
 2016-08-06 19:28:46 +02:00
Javan Makhmali d12209cad2 Remove package:clean task 
Introduced in d6f2000a67 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
 2016-05-24 13:11:28 -04:00
Matthew Draper d6f2000a67 Wrangle the asset build into something that sounds more general 2016-02-01 05:03:03 +10:30
Arun Agrawal 21b6b68f63 Remove unused package tasks 
We are using `all:build` now.
 2015-05-28 09:06:10 +02:00
Arun Agrawal 4194d052d8 Remove broken and unused release task 
- We do release with release.rb
- There is no `rake/gemcutter`
 2015-05-22 14:30:30 +02:00
Matthew Draper e462021396 Revert "For now, we will keep sorting the tests." 
This reverts commit 7025d7769d.
 2015-03-06 04:39:20 +10:30
Robin Dupret 1fac7b79f3 Follow up to #16613 
Since we want this flag to be enabled anytime we are running the tests
under JRuby, let's enable this at the Rakefile level so people get the
performance boost on their local checkout.

Moreover, we avoid having to update this particular line anytime the
option changes on the JRuby side.

The only drawback is that we have to define it in every Rakefile but
there's no big deal, this is already the case for other options.
 2014-09-28 12:04:06 +02:00
Matthew Draper 7025d7769d For now, we will keep sorting the tests. 
This reverts commits e969c92846 and
bd2b3fbe54.
 2014-09-05 23:33:27 +09:30
Akira Matsuda bd2b3fbe54 No need to sort tests 
Dir.glob result must be already sorted anyway
 2014-08-28 14:41:00 +09:00
Arun Agrawal f52832de2a grab executable from rubygems 
As done here d7fc97d3f9
 2013-07-26 11:07:25 +02:00
Arun Agrawal 67f668845e Saying gemcutter => rubygems [ci skip] 2013-06-21 11:04:52 +02:00
Arun Agrawal a84a08ecea No need to load 'rake/packagetask' as it's already 
in 'rubygems/package_task'
 2013-06-02 20:41:21 +02:00
Roman V. Babenko 84feca4aaa Rakefile executable attributes and shebang lines has been removed 2012-05-02 13:38:13 +03:00
Arun Agrawal bfb84cfb3e Verbose output for tests. 
See #3892
 2012-02-03 08:01:24 -05:00
Vijay Dev 79e9a2983a fixes Rake::GemPackageTask deprecation warnings from rake 0.9.0 2011-05-24 23:39:24 +05:30
Santiago Pastorino 9a57a2279e sorry, the CI cannot lie to us anymore (Part II) 2011-01-13 10:55:41 -02:00
raggi cb1570936d Rakefiles are executables, and rake loads rake, not rakefile code 2010-11-25 06:49:55 +08:00
Xavier Noria 43291469cb deletes the rdoc task of each component, they are no longer published separately 2010-08-20 13:30:31 +02:00
Santiago Pastorino cad8bef5ea Bump up rdoc to 2.5.10 2010-08-18 11:44:12 -03:00
Aaron Patterson b50635a59f update Rakefiles for RDoc 2.5 2010-07-23 21:11:29 +02:00
Santiago Pastorino b378b19430 Makes Rakefile activate rdoc >= 2.5.9 
Signed-off-by: Xavier Noria <fxn@hashref.com>
 2010-07-23 00:04:06 +02:00
José Valim 508fba9e07 Add .rdoc extension to README files. 2010-07-21 12:51:14 +02:00
rohit 95a8f252c0 remove executable permission from files that don't need it. [#4802 state:resolved] 
Signed-off-by: José Valim <jose.valim@gmail.com>
 2010-06-20 00:50:48 +02:00
Xavier Noria 01f3f0dbae use RDoc 2.2 to generate the documentation of individual components 2010-06-16 22:30:06 +02:00
Bryan Helmkamp f221a6f19f Leverage VERSION constants from gemspecs to avoid tedious updates when releasing 2010-03-02 00:32:53 -05:00
Bryan Helmkamp 11db694e0b Remove cruft in the gem packaging and release code 2010-03-01 19:00:19 -08:00
Joshua Peek 1a2fba1b6b don't expand test path 2010-02-28 18:26:00 -06:00
Carlhuda 24ab5665b2 Revert "Fix test load paths for those not using bundler" 
This reverts commit eec2d301d4.

This commit broke tests. You cannot have a file called "bundler" on the load path.
 2010-02-23 17:31:17 -08:00
Joshua Peek eec2d301d4 Fix test load paths for those not using bundler 2010-02-15 10:20:11 -06:00
Xavier Noria 9fd9e5d4f7 fixes doc generation 
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
 2010-02-10 14:37:56 -08:00
Jeremy Kemper 459ecaf95d Submarine the rake-gemcutter dep in Rakefiles 2010-02-05 00:03:03 -08:00
Jeremy Kemper 7b81f5981f Fix task defines 2010-02-04 18:44:32 -08:00
Jeremy Kemper c1785f3282 Release using gemcutter gem:push tasks 2010-02-04 18:28:45 -08:00
Joshua Peek 1ab35020c1 Hush AMo test suite 2009-12-16 11:05:48 -06:00
Jeremy Kemper bbb3e5a858 Unify test:isolated across components and run by default at toplevel 2009-11-10 16:50:15 -08:00
Jeremy Kemper a038b3d1bc Make Rakefile usable outside of base dir 2009-11-09 03:31:59 -08:00
Joshua Peek 6094e65169 We won't be publishing tars and zips anymore 2009-10-16 13:56:59 -05:00
Joshua Peek f430d6b63e Make gemspecs the authoritative source instead of generating them from the Rakefile 2009-09-25 00:46:13 -05:00
Joshua Peek 6dc9ad80e6 Fix warnings in AMo 2009-09-05 19:10:21 -05:00
Yehuda Katz 67f5d611f5 Add rake gemspec and gemspecs to the repo 2009-08-31 17:20:44 -07:00
Joshua Peek 66d713fc8f License, version, and gemspec for ActiveModel. Ship it! 2009-08-31 19:09:16 -05:00
Joshua Peek 69742ca8fa Merge branch 'master' into active_model 
Conflicts:
	activemodel/lib/active_model/core.rb
	activemodel/test/cases/state_machine/event_test.rb
	activemodel/test/cases/state_machine/state_transition_test.rb
	activerecord/lib/active_record/validations.rb
	activerecord/test/cases/validations/i18n_validation_test.rb
	activeresource/lib/active_resource.rb
	activeresource/test/abstract_unit.rb
 2009-05-29 16:06:21 -05:00
Jeremy Kemper e8550ee032 Cherry-pick core extensions 2009-05-13 12:00:15 -07:00