Commit Graph

47282 Commits

Author SHA1 Message Date
Rafael Mendonça França 0bd1a4e05c Only include the needed assertions 2014-10-07 20:01:40 -03:00
Rafael Mendonça França 2b3d67d64b Merge pull request #17204 from schneems/schneems/fix-am-tests-master
fix tests on action_mailer
2014-10-07 20:00:17 -03:00
schneems e6b0b760cc fix tests on action_mailer
Include appropriate helpers and use `assert_dom_equal` where applicable
2014-10-07 17:40:59 -05:00
Rafael Mendonça França 4b8f0f8b09 Merge pull request #17203 from schneems/schneems/av-tag_helper
remove un-needed sort
2014-10-07 19:00:01 -03:00
schneems 03d30ce71c remove un-needed sort
HTML doesn't care what order the elements are rendered in, so why should we?

Updates tests to use proper `assert_dom_equal` instead of `assert_equal` /cc @jeremy
2014-10-07 16:54:38 -05:00
Abdelkader Boudih 01aefa5b32 Merge pull request #17201 from djpowers/patch-1
Fix grammar [ci skip]
2014-10-07 21:40:25 +01:00
Dave Powers 8e79abbe63 Fix grammar 2014-10-07 16:32:54 -04:00
Rafael Mendonça França c214dd79cf Merge pull request #17198 from neerajdotname/wordsmitthing
Rephrasing sentences
2014-10-07 12:24:26 -03:00
Rafael Mendonça França cc03ad756a Merge pull request #17184 from fillman/master
fix autoload tests
2014-10-07 12:11:09 -03:00
Rafael Mendonça França fbfc4ac298 Merge pull request #17146 from divineforest/active-record-gsub-to-tr
Change `gsub` to `tr` where possible
2014-10-07 12:07:56 -03:00
Neeraj Singh 590efa49cc Rephrasing sentences 2014-10-07 09:23:51 -04:00
Zachary Scott 3dc9c52ca9 Merge pull request #17189 from jipiboily/update-queue-classic-details
update queue_classic details [ci skip]
2014-10-06 09:51:07 -07:00
Jean-Philippe Boily 76056c627c update queue_classic details 2014-10-06 11:58:45 -04:00
Alexander Balashov 8764ef95dc Change `gsub` to `tr` where possible 2014-10-06 14:03:06 +04:00
Yves Senn fda7bc36e2 unify PG spelling in CHANGELOGs. [ci skip] 2014-10-06 10:30:21 +02:00
fillman 1bf522084c fix autoload tests 2014-10-05 20:28:36 +03:00
Abdelkader Boudih 85c3d5b230 Merge pull request #17183 from prathamesh-sonpatki/fix-typo-in-am-guide
Fix typo in Active Model guide
2014-10-05 14:01:43 +01:00
Prathamesh Sonpatki 391f5dc176 Fix typo in Active Model guide
- instrospection -> introspection.
- [ci skip]
2014-10-05 18:28:42 +05:30
Zachary Scott b56d3adf9b [ci skip] Merge ActiveModel::SecurePassword guide from @aditya-kapoor
Merge branch 'active-model-secure-password-guide' of https://github.com/aditya-kapoor/rails into aditya-kapoor-active-model-secure-password-guide

Conflicts:
	guides/source/active_model_basics.md
2014-10-04 17:21:36 -07:00
Nick Meehan d882348ad2 Edits to ActiveModel guide [ci skip]
- Some grammatical errors and rewording of sentences throughout document

- Renaming headers to be more human readable, and if following paragraphs do not include module
  names, adding those in

- In ActiveModel::AttributeMethods
  * formatting expected output correctly, changing from `#` to `# =>`

- In ActiveModel::Dirty
  * changing expected output of person.first_name_was from "First Name" to nil
  * removing 'active_model' requirement at top of code snippet

- In ActiveModel::Validations
  * originally Person.new(token: "2b1f325") raises an argument error (1 for 0), so setting of
    attribute occurs on the line after object instantiation

- In ActiveModel::Naming
  * closing code snippet tag at end of section so ActiveModel::Model is a separate section

- In ActiveModel::Model
  * fixing spelling mistake of attr_accessor

- In ActiveModel::Serialization
  * adding edit to description of how from_json and from_xml works under serialization

- In ActiveModel::Lint::Tests
  * capitalizing person for class name
2014-10-04 17:08:32 -07:00
Mauro George 8935e8996e Add Active Model to guides [ci skip] 2014-10-04 17:08:14 -07:00
Zachary Scott b5a8fd7bb4 Merge pull request #17179 from eileencodes/clarify-delete-strategies-on-collection-proxy
[ci skip] Clarify deletion strategies for collection proxies
2014-10-04 17:02:25 -07:00
Zachary Scott edc24da940 Merge pull request #17176 from kuldeepaggarwal/doc-alias_method_chain
doc added for `writer` method in `alias_method_chain` [ci skip]
2014-10-04 16:52:13 -07:00
eileencodes 02d3a25361 [ci skip] Clarify deletion strategies for collection proxies
For detailed testing of behavior see:
https://gist.github.com/eileencodes/5b0a2fe011dcff6203fe

This shows destroy_all always destroys records and fires callbacks.
It will never use nullify or delete_all

delete_all's behavior varies greatly based on `hm` vs `hm:t` and deletion
strategy.
2014-10-04 11:36:56 -04:00
Kuldeep Aggarwal 619f82bf18 doc added for `writer` method in `alias_method_chain`[ci skip] 2014-10-04 18:51:50 +05:30
Zachary Scott a4d8b62ed1 Clarify possible validations you can use to avoid a NULL boolean value
in the database. Closes #16304 [ci skip]
2014-10-03 17:37:49 -07:00
Zachary Scott 44e6d91a07 Merge pull request #16409 from justinweiss/update_validation_context_documentation
Docs: Add a note on custom validation contexts. [ci skip]
2014-10-03 17:29:25 -07:00
Matthew Draper cad635995c ❤️ 1.9 2014-10-04 08:41:03 +09:30
Matthew Draper cf66278301 Merge pull request #14146 from chewi/fix-underscore-acronyms-regex
Fix underscore inflector handling of namespaced and adjacent acronyms
2014-10-04 08:16:55 +09:30
Jeremy Kemper 657ce17868 Merge pull request #17150 from effektz/tr-instead-of-gsub
Use #tr instead of #gsub where possible
2014-10-03 15:39:58 -07:00
James Le Cuirot 6a8464fa4f Fix underscore inflector handling of adjacent acronyms
I suspect that positive lookbehind would have been used in the
original implementation had it been available in supported Ruby
versions at the time. Now that Rails requires Ruby 1.9.2 or above,
this is no longer an issue.

This fixes #14146 for acronyms such as APIRESTful. This technique also
addresses namespaced acronyms that are not entirely uppercased. This
was broken when the commit was originally written but has since been
fixed in ccbb481. The latter does not deal with adjacent acronyms so
this commit wins.
2014-10-03 22:45:40 +01:00
Abdelkader Boudih cefb00aac6 Merge pull request #17172 from rselk/typo
fix typo in in define_model_callbacks comment [ci skip]
2014-10-03 22:33:45 +01:00
Ryan Selk 9ded108e84 fix typo in in define_model_callbacks comment [ci skip] 2014-10-03 15:31:14 -06:00
Xavier Noria 1609ec9879 Merge pull request #17168 from jwworth/task/fix_typo
Fix typo [ci skip]
2014-10-03 21:40:57 +02:00
Jake Worth d7175887b4 Fix typo 2014-10-03 14:28:41 -05:00
Rafael Mendonça França 9596f122d6 Merge pull request #17167 from kuldeepaggarwal/doc-define_model_callbacks
add notes for `define_model_callbacks`
2014-10-03 14:35:15 -03:00
Kuldeep Aggarwal f50430ee3e add notes for `define_model_callbacks` [ci skip] 2014-10-03 23:04:01 +05:30
Aaron Patterson 23ef52514e Merge pull request #17160 from lsylvester/duration-hash
define hash on duration
2014-10-03 16:52:25 +02:00
lsylvester 6c57c78671 define hash on duration 2014-10-03 19:53:54 +10:00
Xavier Noria de50a91daa minor fixes in the configuring guide [ci skip] 2014-10-03 09:24:12 +02:00
Xavier Noria 78a14189d9 Revert "Fix style for rescue responses doc [ci skip]"
Reason: There is a wrong newline, a typo, and the change
to singular is not good.

This reverts commit d76380cf1c.
2014-10-03 09:20:48 +02:00
Abdelkader Boudih c9e510c1a8 Merge pull request #17153 from yuki24/fix-doc-format-for-rescue-responses
[Railsguides] Fix style for rescue responses doc [ci skip]
2014-10-03 05:40:32 +01:00
Abdelkader Boudih d93854ffc9 Merge pull request #17151 from y-yagi/patch-1
[ci skip] add `test:jobs` task to testing guide
2014-10-03 05:37:13 +01:00
Yuki Nishijima d76380cf1c Fix style for rescue responses doc [ci skip]
* Change 'Any ***s that are...' to 'Any *** that is...'
 * Fix style for default rescue_responses setting

This is a follow-up commit to:

 * https://github.com/rails/rails/pull/17076
 * 89b8836f24
2014-10-02 19:01:33 -07:00
yuuji.yaginuma 25895427c3 [ci skip] add `test:jobs` task to testing guide 2014-10-03 08:50:28 +09:00
Alex Weidmann afb92754c8 Use #tr instead of #gsub where possible 2014-10-02 17:35:13 -06:00
Xavier Noria 29006a7795 Merge pull request #17148 from mgenereu/patch-1
Disallow appended newlines when parsing as integer
2014-10-02 23:03:29 +02:00
Michael Genereux 4e511001b4 Disallow appended newlines when parsing as integer
\Z allows appended newlines where \z does not.
2014-10-02 13:55:22 -07:00
Abdelkader Boudih 4cd57a88b4 Merge pull request #17068 from mokhan/update-active-job-documentation
[ci-skip] Update Active Job API documentation
2014-10-02 18:10:55 +01:00
mo khan bc6421c9ef Add documentation on Active Job.
This adds documentation for the Active Job API. It includes
documentation on how to configure the queue_adapter, and how to create
new jobs. It adds links to the various other sections of the Active Job
documentation.
2014-10-02 10:57:30 -06:00