Commit Graph

80 Commits

Author SHA1 Message Date
zzak dd89f600f7
🔗 Remove RDoc auto-link from Rails module everywhere 2023-06-23 10:49:30 +09:00
zzak 722d4f6582
Unlink Rails constant from READMEs 2023-05-29 15:14:44 +09:00
zzak f8544410a2 Use stable guides link for package READMEs
E.g.: These show up here:
https://api.rubyonrails.org/files/actioncable/README_md.html
2023-02-04 09:01:00 +09:00
Abhay Nikam bdfffd1355 Update the Rails mailing list URLs to new discuss discourse URL [ci skip] 2020-04-02 22:00:28 +05:30
Abhay Nikam 476abd403b Updated links from http to https in guides, docs, etc 2019-03-09 16:43:47 +05:30
bogdanvlviv 8e7d9ce8cb
Merge `actioncable/README.md` to the Action Cable Overview guide [ci skip]
In #34709 we updated the guide, but `actioncable/README.md` is still
outdated. Instead of fixing content in the file. I suggest
not duplicate the info that is already in the guide and instead remove
the info from the file and just add a message:
"You can read more about Action Cable in the
[Action Cable Overview](https://edgeguides.rubyonrails.org/action_cable_overview.html) guide."

The same approach is being used for Action Mailbox and Action Text,
see #34812 and #34878.
2019-01-13 19:45:04 +00:00
Javan Makhmali 86b489e3d6 Move all npm packages to @rails scope
Fixes #33083
2019-01-10 11:01:57 -05:00
Greg Molnar d1a32f314c fix broken link in Action Cable guides and readme [ci skip] 2018-10-08 17:07:03 +02:00
nisusam c9fd722851 Update link for `Rack socket hijacking API`
- Use valid `fragment identifier` in the URL
- Use `https`
2018-09-04 14:49:49 +05:30
Fatos Morina 37cf9b3466 Fix typos and add a few suggestions 2017-11-28 19:27:43 +01:00
Rafael Mendonça França 48766e32d3
Removed deprected evented redis adapter 2017-10-23 12:50:45 -04:00
Yauheni Dakuka c9527652c7 Fix quotes [ci skip] 2017-09-18 09:38:47 +03:00
Yoshiyuki Hirano 3a11e0586e Update MIT licenses link [ci skip] 2017-08-22 08:46:02 +09:00
Claudio B af954ddd54 [ci skip] Prefer cookies.encrypted over signed (#30129)
In some examples and guides we are recommending to use code like:

```ruby
verified_user = User.find_by(id: cookies.signed[:user_id])
```

My suggestion is to use instead:

```ruby
verified_user = User.find_by(id: cookies.encrypted[:user_id])
```

which invites users to prefer the "newer" encrypted cookies over the
"legacy" signed cookies.
2017-08-07 22:32:03 -05:00
bogdanvlviv 6673cf7071
Use `require_relative` instead of `require` with full path 2017-06-14 12:10:17 +03:00
bogdanvlviv 40bdbce191
Define path with __dir__
".. with __dir__ we can restore order in the Universe." - by @fxn

Related to 5b8738c2df
2017-05-23 00:53:51 +03:00
Ryuta Kamizono bdbee0b8e5 Rename local variable name `current_user` to `verified_user` [ci skip]
Assigning local variable named `current_user` in the condition is
confusing.
2017-03-25 20:48:34 +09:00
Kasper Timm Hansen b242796765 Revert "Merge pull request #28569 from HarryCollins/patch-1"
This reverts commit 296d024b4e, reversing
changes made to e341d83507.

We aren't trying to compare to current_user, we're assigning that variable.
2017-03-25 12:40:53 +01:00
HarryCollins 591891e51e Update Action Cable README.md - typo fix 2017-03-25 10:45:31 +00:00
Rafael França a27c040cc3 Merge pull request #25626 from maclover7/jm-standardize-ac-readme
Standardize Action Cable README.md
2017-01-03 19:35:39 -05:00
Akira Matsuda 91fa2b71c3 Privatize unneededly protected methods in Action Cable 2016-12-24 22:16:43 +09:00
Matthew Draper dae4044734 Permit same-origin connections by default
WebSocket always defers the decision to the server, because it didn't
have to deal with legacy compatibility... but the same-origin policy is
still a reasonable default.

Origin checks do not protect against a directly connecting attacker --
they can lie about their host, but can also lie about their origin.
Origin checks protect against a connection from 3rd-party controlled
script in a context where a victim browser's cookies will be passed
along. And if an attacker has breached that protection, they've already
compromised the HTTP session, so treating the WebSocket connection in
the same way seems reasonable.

In case this logic proves incorrect (or anyone just wants to be more
paranoid), we retain a config option to disable it.
2016-10-11 12:51:10 +10:30
Matthew Draper f8c53eff7b Merge pull request #26568 from skateman/cable-sameorigin-as-host
Optionally allow ActionCable requests from the same host as origin
2016-10-11 12:28:38 +10:30
kenta-s a0f871f95a Change page:change to turbolinks:load in README.md [ci skip] 2016-10-05 19:41:27 +09:00
Dávid Halász 268c340b09 Optionally allow ActionCable requests from the same host as origin
When the `allow_same_origin_as_host` is set to `true`, the request
forgery protection permits `HTTP_ORIGIN` values starting with the
corresponding `proto://` prefix followed by `HTTP_HOST`. This way
it is not required to specify the list of allowed URLs.
2016-09-21 16:10:46 +02:00
Jon Moss eff98450ff Standardize Action Cable README.md
All other Rails components feature this section, Action Cable should
have it as well.

[ci skip]
2016-07-02 12:13:33 -04:00
Vipul A M e5c5b6f2ee Merge pull request #24991 from maclover7/actioncable-npm-docs
Add documentation about Action Cable npm package
2016-06-29 15:29:59 -07:00
Rafael Mendonça França e78e0e2a42
Fix Action Cable README [ci skip] 2016-06-26 16:09:36 -03:00
Ryuta Kamizono e317e5e1e1 Remove conflict line [ci skip] 2016-06-27 02:52:39 +09:00
Vijay Dev 5343626ea8 Merge branch 'master' of github.com:rails/docrails
Conflicts:
	actioncable/README.md
2016-06-26 16:34:23 +00:00
Vipul A M b94b04b1d1
Fix and make example generic in README as well [ci skip] 2016-06-15 22:04:56 -07:00
Prathamesh Sonpatki 7d4b33257b
Added "Download and Installation" section to Action Cable README [ci skip]
- Only Action Cable README did not have this section, all of the other
  READMEs have this section.
2016-06-04 16:06:35 -04:00
Prathamesh Sonpatki 4c192a7fad
Trim Action Cable README [ci skip]
- Remove "Configuration", "Running the server", "Dependencies" and "Deployment"
  sections from the Action Cable README as they are already duplicated in the
  Action Cable overview guide.
2016-06-04 16:01:30 -04:00
Rajat Bansal 72a0f5e24c fix grammar 2016-05-31 13:31:18 +05:30
Anubhav Saxena 5983226161 Bash markdown syntax
Added 'sh' for markdown formatting as bash.
2016-05-27 08:58:55 +05:30
Jon Moss 1713075a80 Add documentation about Action Cable npm package
Sorry, forgot to include in my main PR :(

[ci skip]

[Jon Moss, Zach Schneider]
2016-05-26 22:22:04 -04:00
yuuji.yaginuma 017c7f46e0 change cable.coffee to cable.js [ci skip]
In #23935, cable file was to be provided by the javascript instead of coffeescript,
doc was also been modified to use javascript.
2016-05-07 21:15:33 +02:00
Jon Moss 7d55c846f1 http --> https
[ci skip]
2016-05-06 17:59:27 -04:00
willnet 11d41c6ef8 [ci skip] Fix ActionCable README
default worker pool size was changed from 100 to 4 at #24376
2016-05-02 23:33:12 +09:00
Vipul A M 7165714637 Merge pull request #24600 from tomkadwill/action-cabel-channel-typos
Fix typos in ActionCable Channel [ci skip]
2016-04-18 19:20:27 +05:30
Tom Kadwill 2ef18c1ebc Fix typos in ActionCable Channel [ci skip] 2016-04-18 08:43:50 +01:00
yuuji.yaginuma a2f034335d update example to specify the Action Cable mount path [ci skip]
Follow up to 8b69f1e
2016-04-15 19:16:01 +09:00
Bouke van der Bijl 242abf8850 Remove inconsistency in the Action Cable README [ci skip] 2016-02-29 20:25:30 -05:00
Hayley Anderson b425a86591 Add small Action Cable documentation fixes
* Fix typos/grammar errors
* Make capitalization/naming consistent
2016-02-27 13:53:31 -05:00
Mehmet Emin İNAÇ e8f4954086 Action Cable readme fix [ci skip] 2016-02-23 04:16:22 +02:00
Jon Moss 05088b6299 Full Action Cable documentation read through
This PR checks all active Action Cable documentation for typos and other
fixes. It aims to make sure that when Rails 5 is released, that the
Action Cable docs are up to snuff with the other documentation included
with Rails.

[ci skip]
2016-02-17 11:08:00 -05:00
Jon Moss 887d34c7f6 Merge pull request #23546 from maclover7/cable-readme-update
ActionCable README updates
2016-02-11 16:53:36 -05:00
Mawueli Kofi Adzoe f2fcd3a000 Fix tiny grammar. 2016-02-09 22:35:40 -07:00
Ryuta Kamizono 3f184cab48 Fix typo [ci skip] 2016-02-09 09:47:47 +09:00
Jon Moss 1fddb0e622 ActionCable README updates
[ci skip]
2016-02-08 17:21:55 -05:00