mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix `TestInvalidUrls` with rack 2.0.3 

Currently, raise `BadRequest` if params encoding is invalid.
https://github.com/rails/rails/blob/5-1-stable/actionpack/lib/action_dispatch/http/parameters.rb#L64..L74
https://github.com/rails/rails/blob/5-1-stable/actionpack/lib/action_dispatch/request/utils.rb#L26..L39

However, env values are ensure encoded in ASCII 8 BIT at rack 2.0.3.
68db9aa99e

Therefore, even if specify an invalid urls, it will not cause an error.
This commit is contained in:
yuuji.yaginuma 2017-05-16 07:45:41 +09:00
parent 6086fbaecf
commit e605921614
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
actionpack/test/dispatch/routing_test.rb
View File

@ -4419,7 +4419,7 @@ class TestInvalidUrls < ActionDispatch::IntegrationTest
end
end
test "invalid UTF-8 encoding returns a 400 Bad Request" do
test "invalid UTF-8 encoding is treated as ASCII 8BIT encode" do
with_routing do |set|
set.draw do
get "/bar/:id", to: redirect("/foo/show/%{id}")
@ -4435,19 +4435,19 @@ class TestInvalidUrls < ActionDispatch::IntegrationTest
end
get "/%E2%EF%BF%BD%A6"
assert_response :bad_request
assert_response :not_found
get "/foo/%E2%EF%BF%BD%A6"
assert_response :bad_request
assert_response :not_found
get "/foo/show/%E2%EF%BF%BD%A6"
assert_response :bad_request
assert_response :ok
get "/bar/%E2%EF%BF%BD%A6"
assert_response :bad_request
assert_response :redirect
get "/foobar/%E2%EF%BF%BD%A6"
assert_response :bad_request
assert_response :ok
end
end
end