mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

PR template: note about auto-closing issue 

I've noticed a few PRs made since the latest template update, that have said things like "this PR was created because of #ISSUE" or things along those lines. It seems like people are reading the template and following its advice! But Github requires a specific syntax to auto-close an issue, so we may as well encourage people to use that to save everyone a bit of time. So in this PR I've added a comment to the template explaining that.
This commit is contained in:
Alex Ghiculescu 2022-10-22 09:23:29 -05:00 committed by GitHub
parent 908f7bd01e
commit cccbc092ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.github/pull_request_template.md vendored
View File

@ -20,7 +20,10 @@ Feel free to discard it if you need to (e.g. when you just fix a typo). -->
### Motivation / Background ### Motivation / Background
<!-- Describe why this Pull Request needs to be merged. What bug have you fixed? What feature have you added? Why is it important? --> <!--
Describe why this Pull Request needs to be merged. What bug have you fixed? What feature have you added? Why is it important?
If you are fixing a specific issue, include "Fixes #ISSUE" (replace with the issue number, remove the quotes) and the issue will be linked to to this PR.
-->
This Pull Request has been created because [REPLACE ME] This Pull Request has been created because [REPLACE ME]