mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #44529 from Shopify/actionview-fix-flaky-tests 

Fix flaky Action View tests
This commit is contained in:
Rafael Mendonça França 2022-02-25 14:47:49 -05:00 committed by GitHub
parent cefaf15810 6e56e18523
commit b64cbc0b27
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
actionview/test/actionpack/controller/view_paths_test.rb
View File

@ -30,6 +30,8 @@ class ViewLoadPathsTest < ActionController::TestCase
end
def setup
ActionView::LookupContext::DetailsKey.clear
@controller = TestController.new
@request = ActionController::TestRequest.create(@controller.class)
@response = ActionDispatch::TestResponse.new

5
actionview/test/activerecord/render_partial_with_record_identification_test.rb
View File

@ -52,6 +52,11 @@ class RenderPartialWithRecordIdentificationTest < ActiveRecordTestCase
tests RenderPartialWithRecordIdentificationController
fixtures :developers, :projects, :developers_projects, :topics, :replies, :companies, :mascots
def setup
super
ActionView::LookupContext::DetailsKey.clear
end
def test_rendering_partial_with_has_many_and_belongs_to_association
get :render_with_has_many_and_belongs_to_association
assert_equal Developer.find(1).projects.map(&:name).join, @response.body

2
actionview/test/template/render_test.rb
View File

@ -712,6 +712,8 @@ class FrozenStringLiteralEnabledViewRenderTest < ActiveSupport::TestCase
include RenderTestCases
def setup
ActionView::LookupContext::DetailsKey.clear
@previous_frozen_literal = ActionView::Template.frozen_string_literal
ActionView::Template.frozen_string_literal = true
view_paths = ActionController::Base.view_paths