mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove deprecated file `active_support/core_ext/numeric/inquiry`

This commit is contained in:
Rafael Mendonça França 2020-10-28 21:51:17 +00:00
parent b8a8a66993
commit 959af4bfcb
No known key found for this signature in database
GPG Key ID: FC23B6D0F1EEE948
5 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
activesupport/CHANGELOG.md
View File

@ -1,3 +1,7 @@
* Remove deprecated file `active_support/core_ext/numeric/inquiry`.
*Rafael Mendonça França*
* Remove deprecated file `active_support/core_ext/module/reachable`.
*Rafael Mendonça França*

1
activesupport/lib/active_support/core_ext/numeric/conversions.rb
View File

@ -2,7 +2,6 @@
require "active_support/core_ext/big_decimal/conversions"
require "active_support/number_helper"
require "active_support/core_ext/module/deprecation"
module ActiveSupport
module NumericWithFormat

5
activesupport/lib/active_support/core_ext/numeric/inquiry.rb
View File

@ -1,5 +0,0 @@
# frozen_string_literal: true
require "active_support/deprecation"
ActiveSupport::Deprecation.warn "Ruby 2.5+ (required by Rails 6) provides Numeric#positive? and Numeric#negative? natively, so requiring active_support/core_ext/numeric/inquiry is no longer necessary. Requiring it will raise LoadError in Rails 6.1."

6
activesupport/test/core_ext/numeric_ext_test.rb
View File

@ -411,10 +411,4 @@ class NumericExtFormattingTest < ActiveSupport::TestCase
def test_in_milliseconds
assert_equal 10_000, 10.seconds.in_milliseconds
end
def test_requiring_inquiry_is_deprecated
assert_deprecated do
require "active_support/core_ext/numeric/inquiry"
end
end
end

2
guides/source/6_1_release_notes.md
View File

@ -294,6 +294,8 @@ Please refer to the [Changelog][active-support] for detailed changes.
* Remove deprecated file `active_support/core_ext/module/reachable`.
* Remove deprecated file `active_support/core_ext/numeric/inquiry`.
### Deprecations
### Notable changes