Fix how to compute class name on habtm namespaced.

Thank's for @laurocaetano for the help with tests. 😃

Fixes #14709
This commit is contained in:
Kassio Borges 2014-05-13 11:25:21 -03:00
parent c6c1642383
commit 8f6e5986ac
7 changed files with 42 additions and 1 deletions

View File

@ -1,3 +1,9 @@
* Fix how to calculate associated class name when using `habtm` namespaced.
Fixes #14709.
*Kassio Borges*
* `change_column_default` allows `[]` as argument to `change_column_default`. * `change_column_default` allows `[]` as argument to `change_column_default`.
Fixes #11586. Fixes #11586.

View File

@ -23,7 +23,11 @@ module ActiveRecord::Associations::Builder
KnownTable.new options[:join_table].to_s KnownTable.new options[:join_table].to_s
else else
class_name = options.fetch(:class_name) { class_name = options.fetch(:class_name) {
name.to_s.camelize.singularize model_name = name.to_s.camelize.singularize
if parent_name = lhs_class.parent_name.presence
model_name = model_name.prepend("#{parent_name}::")
end
model_name
} }
KnownClass.new lhs_class, class_name KnownClass.new lhs_class, class_name
end end

View File

@ -22,6 +22,9 @@ require 'models/sponsor'
require 'models/country' require 'models/country'
require 'models/treaty' require 'models/treaty'
require 'models/vertex' require 'models/vertex'
require 'models/publisher'
require 'models/publisher/article'
require 'models/publisher/magazine'
require 'active_support/core_ext/string/conversions' require 'active_support/core_ext/string/conversions'
class ProjectWithAfterCreateHook < ActiveRecord::Base class ProjectWithAfterCreateHook < ActiveRecord::Base
@ -848,4 +851,13 @@ class HasAndBelongsToManyAssociationsTest < ActiveRecord::TestCase
def test_custom_join_table def test_custom_join_table
assert_equal 'edges', Vertex.reflect_on_association(:sources).join_table assert_equal 'edges', Vertex.reflect_on_association(:sources).join_table
end end
def test_namespaced_habtm
magazine = Publisher::Magazine.create
article = Publisher::Article.create
magazine.articles << article
magazine.save
assert_includes magazine.articles, article
end
end end

View File

@ -0,0 +1,2 @@
module Publisher
end

View File

@ -0,0 +1,3 @@
class Publisher::Article < ActiveRecord::Base
has_and_belongs_to_many :magazines
end

View File

@ -0,0 +1,3 @@
class Publisher::Magazine < ActiveRecord::Base
has_and_belongs_to_many :articles
end

View File

@ -62,6 +62,14 @@ ActiveRecord::Schema.define do
t.string :name t.string :name
end end
create_table :articles, force: true do |t|
end
create_table :articles_magazines, force: true do |t|
t.references :article
t.references :magazine
end
create_table :audit_logs, force: true do |t| create_table :audit_logs, force: true do |t|
t.column :message, :string, null: false t.column :message, :string, null: false
t.column :developer_id, :integer, null: false t.column :developer_id, :integer, null: false
@ -385,6 +393,9 @@ ActiveRecord::Schema.define do
t.column :custom_lock_version, :integer t.column :custom_lock_version, :integer
end end
create_table :magazines, force: true do |t|
end
create_table :mateys, id: false, force: true do |t| create_table :mateys, id: false, force: true do |t|
t.column :pirate_id, :integer t.column :pirate_id, :integer
t.column :target_id, :integer t.column :target_id, :integer