Accidentally checked in commented test code. Fail. >_<
This commit is contained in:
Jon Leighton 2012-09-15 00:41:56 +01:00
parent 02f56554d6
commit 60c88e64e2
2 changed files with 21 additions and 15 deletions

View File

@ -35,10 +35,8 @@ module ActiveRecord
end
class OpenTransaction < Transaction #:nodoc:
attr_reader :parent, :records
attr_accessor :joinable
alias joinable? joinable
attr_reader :parent, :records
attr_writer :joinable
def initialize(connection, parent)
super connection
@ -46,6 +44,18 @@ module ActiveRecord
@parent = parent
@records = []
@finishing = false
@joinable = true
end
# This state is necesarry so that we correctly handle stuff that might
# happen in a commit/rollback. But it's kinda distasteful. Maybe we can
# find a better way to structure it in the future.
def finishing?
@finishing
end
def joinable?
@joinable && !finishing?
end
def number
@ -56,16 +66,12 @@ module ActiveRecord
end
end
# Database adapters expect that #open_transactions will be decremented
# before we've actually executed a COMMIT or ROLLBACK. This is kinda
# annoying, but for now we use this @finishing flag to toggle what value
# #number should return.
def finishing?
@finishing
end
def begin
SavepointTransaction.new(connection, self)
if finishing?
parent.begin
else
SavepointTransaction.new(connection, self)
end
end
def rollback

View File

@ -354,7 +354,7 @@ class SaveFromAfterCommitBlockTest < ActiveRecord::TestCase
def test_after_commit_in_save
topic = TopicWithSaveInCallback.new()
topic.save
# assert_equal true, topic.cached
# assert_equal true, topic.record_updated
assert_equal true, topic.cached
assert_equal true, topic.record_updated
end
end