mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove unnecessary &block from Range#sum and add tests for (num..float).sum

This commit is contained in:
Pratik Naik 2009-08-09 18:15:13 +01:00
parent 97a5c7a516
commit 60bed59fbf
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
activesupport/lib/active_support/core_ext/enumerable.rb
View File

@ -115,7 +115,7 @@ end
class Range #:nodoc:
# Optimize range sum to use arithmetic progression if a block is not given and
# we have a range of numeric values.
def sum(identity=0, &block)
def sum(identity = 0)
return super if block_given? || !(first.instance_of?(Integer) && last.instance_of?(Integer))
actual_last = exclude_end? ? (last - 1) : last
(actual_last - first + 1) * (actual_last + first) / 2

1
activesupport/test/core_ext/enumerable_test.rb
View File

@ -66,6 +66,7 @@ class EnumerableTests < Test::Unit::TestCase
assert_equal 10, (1..4).sum
assert_equal 6, (1...4).sum
assert_equal 'abc', ('a'..'c').sum
assert_raises(NoMethodError) { 1..2.5.sum }
end
def test_each_with_object