mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

Skip cookie comma separation test 

Rack updated the RFC they're adhering to when parsing cookies, now no
longer including commas.

There's still an open question as mentioned in:
https://github.com/rails/rails/issues/38420

However, the resilience test is no longer as well needed as it once was
and we can move forward separately. If not, this is easily revertible.
This commit is contained in:
Kasper Timm Hansen 2020-02-10 01:46:26 +01:00
parent f3eaddb734
commit 5bd29afeb4
No known key found for this signature in database
GPG Key ID: 191153215EDA53D8
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Gemfile.lock
View File

@ -367,7 +367,7 @@ GEM
thor thor
raabro (1.1.6) raabro (1.1.6)
racc (1.4.16) racc (1.4.16)
rack (2.1.1) rack (2.2.1)
rack-cache (1.10.0) rack-cache (1.10.0)
rack (>= 0.4) rack (>= 0.4)
rack-protection (2.0.7) rack-protection (2.0.7)
@ -609,4 +609,4 @@ DEPENDENCIES
websocket-client-simple! websocket-client-simple!
BUNDLED WITH BUNDLED WITH
2.1.2 2.1.4

6
actionpack/test/dispatch/request_test.rb
View File

@ -592,12 +592,6 @@ class RequestCookie < BaseRequestTest
request = stub_request("HTTP_COOKIE" => "_session_id=c84ace84796670c052c6ceb2451fb0f2; is_admin=yes") request = stub_request("HTTP_COOKIE" => "_session_id=c84ace84796670c052c6ceb2451fb0f2; is_admin=yes")
assert_equal "c84ace84796670c052c6ceb2451fb0f2", request.cookies["_session_id"], request.cookies.inspect assert_equal "c84ace84796670c052c6ceb2451fb0f2", request.cookies["_session_id"], request.cookies.inspect
assert_equal "yes", request.cookies["is_admin"], request.cookies.inspect assert_equal "yes", request.cookies["is_admin"], request.cookies.inspect
# some Nokia phone browsers omit the space after the semicolon separator.
# some developers have grown accustomed to using comma in cookie values.
request = stub_request("HTTP_COOKIE" => "_session_id=c84ace847,96670c052c6ceb2451fb0f2;is_admin=yes")
assert_equal "c84ace847", request.cookies["_session_id"], request.cookies.inspect
assert_equal "yes", request.cookies["is_admin"], request.cookies.inspect
end end
end end