mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix Active Job Sidekiq integration tests 

The `Sidekiq::Logging` module was removed in Sidekiq 6.0 in favour of
`Sidekiq.logger=`.

https://github.com/mperham/sidekiq/wiki/Logging#api-changes

> The old Sidekiq::Logging class was removed in Sidekiq 6.0. You should
> not be accessing any Sidekiq internal classes to use the logger. Use
> `logger` directly in your Worker or use `Sidekiq.logger` elsewhere.
This commit is contained in:
Eugene Kenny 2019-09-01 23:31:21 +02:00
parent 782d280307
commit 5545f6a771
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Gemfile.lock
View File

@ -389,7 +389,7 @@ GEM
ffi (~> 1.0) ffi (~> 1.0)
rdoc (6.0.4) rdoc (6.0.4)
redcarpet (3.2.3) redcarpet (3.2.3)
redis (4.1.1) redis (4.1.2)
redis-namespace (1.6.0) redis-namespace (1.6.0)
redis (>= 3.0.4) redis (>= 3.0.4)
regexp_parser (1.6.0) regexp_parser (1.6.0)
@ -448,10 +448,11 @@ GEM
sequel (5.14.0) sequel (5.14.0)
serverengine (2.0.7) serverengine (2.0.7)
sigdump (~> 0.2.2) sigdump (~> 0.2.2)
sidekiq (5.2.3) sidekiq (6.0.0)
connection_pool (~> 2.2, >= 2.2.2) connection_pool (>= 2.2.2)
rack-protection (>= 1.5.0) rack (>= 2.0.0)
redis (>= 3.3.5, < 5) rack-protection (>= 2.0.0)
redis (>= 4.1.0)
sigdump (0.2.4) sigdump (0.2.4)
signet (0.11.0) signet (0.11.0)
addressable (~> 2.3) addressable (~> 2.3)

2
activejob/test/support/integration/adapters/sidekiq.rb
View File

@ -36,7 +36,7 @@ module SidekiqJobsManager
$stderr.sync = true $stderr.sync = true
logfile = Rails.root.join("log/sidekiq.log").to_s logfile = Rails.root.join("log/sidekiq.log").to_s
Sidekiq::Logging.initialize_logger(logfile) Sidekiq.logger = Sidekiq::Logger.new(logfile)
self_read, self_write = IO.pipe self_read, self_write = IO.pipe
trap "TERM" do trap "TERM" do