Rename `#assert_not_has_stream` `#assert_has_no_stream`

This is a follow-up to https://github.com/rails/rails/pull/50585.

I propose to provide smoother reading experiences with the two methods
introduced in there, `#assert_not_has_stream` and `#assert_not_has_stream_for`,
by renaming them `#assert_has_no_stream` and `#assert_has_no_stream_for`, respectively.
This commit is contained in:
Junichi Sato 2024-01-05 11:14:41 +09:00
parent a2ed3437e3
commit 523f86964f
No known key found for this signature in database
GPG Key ID: 6CEF8C0F22CB941D
3 changed files with 15 additions and 15 deletions

View File

@ -1,13 +1,13 @@
* Add two new assertion methods for ActionCable test cases: `assert_not_has_stream`
and `assert_not_has_stream_for`. These methods can be used to assert that a
* Add two new assertion methods for ActionCable test cases: `assert_has_no_stream`
and `assert_has_no_stream_for`. These methods can be used to assert that a
stream has been stopped, e.g. via `stop_stream` or `stop_stream_for`. They complement
the already existing `assert_has_stream` and `assert_has_stream_for` methods.
```ruby
assert_not_has_stream "messages"
assert_not_has_stream_for User.find(42)
assert_has_no_stream "messages"
assert_has_no_stream_for User.find(42)
```
*Sebastian Pöll*
*Sebastian Pöll*, *Junichi Sato*
Please check [7-1-stable](https://github.com/rails/rails/blob/7-1-stable/actioncable/CHANGELOG.md) for previous changes.

View File

@ -314,24 +314,24 @@ module ActionCable
# Asserts that the specified stream has not been started.
#
# def test_assert_not_started_stream
# def test_assert_no_started_stream
# subscribe
# assert_not_has_stream 'messages'
# assert_has_no_stream 'messages'
# end
#
def assert_not_has_stream(stream)
def assert_has_no_stream(stream)
assert subscription.streams.exclude?(stream), "Stream #{stream} has been started"
end
# Asserts that the specified stream for a model has not started.
#
# def test_assert_not_started_stream_for
# def test_assert_no_started_stream_for
# subscribe id: 41
# assert_not_has_stream_for User.find(42)
# assert_has_no_stream_for User.find(42)
# end
#
def assert_not_has_stream_for(object)
assert_not_has_stream(broadcasting_for(object))
def assert_has_no_stream_for(object)
assert_has_no_stream(broadcasting_for(object))
end
private

View File

@ -111,14 +111,14 @@ class StreamsTestChannelTest < ActionCable::Channel::TestCase
subscribe
unsubscribe
assert_not_has_stream "test_0"
assert_has_no_stream "test_0"
end
def test_not_stream_with_params
subscribe id: 42
perform :unsubscribed, id: 42
assert_not_has_stream "test_42"
assert_has_no_stream "test_42"
end
def test_unsubscribe_from_stream
@ -150,7 +150,7 @@ class StreamsForTestChannelTest < ActionCable::Channel::TestCase
subscribe id: 42
perform :unsubscribed, id: 42
assert_not_has_stream_for User.new(42)
assert_has_no_stream_for User.new(42)
end
end