mirror of https://github.com/rails/rails
Use optimized subclass of StringInquirer for Rails.env
This adds a StringInquirer subclass EnvironmentInquirer that predefines the three default environments as query methods, in order to avoid dispatching through `method_missing` for every call to those methods. The original StringInquirer was not modified due to the side effects of having new env-related methods on it. This new class was not implemented using lazy method definition to avoid the open-ended possibility of defining a new method for all query calls. The three default environments should cover a high percentage of real-world uses, and users with custom environments could add their own to this class. Fixes #37803.
This commit is contained in:
parent
4fe767535d
commit
516b8a5f69
|
@ -1,6 +1,7 @@
|
|||
# frozen_string_literal: true
|
||||
|
||||
require "active_support/string_inquirer"
|
||||
require "active_support/environment_inquirer"
|
||||
|
||||
class String
|
||||
# Wraps the current string in the <tt>ActiveSupport::StringInquirer</tt> class,
|
||||
|
|
|
@ -0,0 +1,16 @@
|
|||
# frozen_string_literal: true
|
||||
|
||||
module ActiveSupport
|
||||
# This is a special case of StringInquirer that defines the three default
|
||||
# environments at construction time based on the environment string.
|
||||
class EnvironmentInquirer < StringInquirer
|
||||
DEFAULT_ENVIRONMENTS = ["development", "test", "production"]
|
||||
def initialize(env)
|
||||
super(env)
|
||||
|
||||
DEFAULT_ENVIRONMENTS.each do |default_env|
|
||||
singleton_class.define_method(:"#{env}?", (env == default_env).method(:itself))
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
|
@ -70,14 +70,14 @@ module Rails
|
|||
# Rails.env.development? # => true
|
||||
# Rails.env.production? # => false
|
||||
def env
|
||||
@_env ||= ActiveSupport::StringInquirer.new(ENV["RAILS_ENV"].presence || ENV["RACK_ENV"].presence || "development")
|
||||
@_env ||= ActiveSupport::EnvironmentInquirer.new(ENV["RAILS_ENV"].presence || ENV["RACK_ENV"].presence || "development")
|
||||
end
|
||||
|
||||
# Sets the Rails environment.
|
||||
#
|
||||
# Rails.env = "staging" # => "staging"
|
||||
def env=(environment)
|
||||
@_env = ActiveSupport::StringInquirer.new(environment)
|
||||
@_env = ActiveSupport::EnvironmentInquirer.new(environment)
|
||||
end
|
||||
|
||||
# Returns all Rails groups for loading based on:
|
||||
|
|
Loading…
Reference in New Issue