From 5005480adf5057b7efe9197a8d8b7a716c91bec5 Mon Sep 17 00:00:00 2001 From: Hartley McGuire Date: Fri, 20 Oct 2023 12:50:18 -0400 Subject: [PATCH] Add racc dependency because it will be bundled Ruby 3.3.0 is going to start warning for racc not being specififed as a dependency, and Ruby 3.4.0 will raise if it is not specified. This commit prevents those issues by adding racc to the Action Pack gemspec, since `racc/parser` is a runtime dependency of the Journey parser. --- Gemfile.lock | 1 + actionpack/CHANGELOG.md | 3 +++ actionpack/actionpack.gemspec | 1 + 3 files changed, 5 insertions(+) diff --git a/Gemfile.lock b/Gemfile.lock index d27a1dfa797..e1f9169aa17 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -50,6 +50,7 @@ PATH actionview (= 7.2.0.alpha) activesupport (= 7.2.0.alpha) nokogiri (>= 1.8.5) + racc rack (>= 2.2.4) rack-session (>= 1.0.1) rack-test (>= 0.6.3) diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md index 4ff4f1eb32c..34330016469 100644 --- a/actionpack/CHANGELOG.md +++ b/actionpack/CHANGELOG.md @@ -1,2 +1,5 @@ +* Add `racc` as a dependency since it will become a bundled gem in Ruby 3.4.0 + + *Hartley McGuire* Please check [7-1-stable](https://github.com/rails/rails/blob/7-1-stable/actionpack/CHANGELOG.md) for previous changes. diff --git a/actionpack/actionpack.gemspec b/actionpack/actionpack.gemspec index c0606c6fbb6..c4a311dd2c1 100644 --- a/actionpack/actionpack.gemspec +++ b/actionpack/actionpack.gemspec @@ -36,6 +36,7 @@ Gem::Specification.new do |s| s.add_dependency "activesupport", version s.add_dependency "nokogiri", ">= 1.8.5" + s.add_dependency "racc" s.add_dependency "rack", ">= 2.2.4" s.add_dependency "rack-session", ">= 1.0.1" s.add_dependency "rack-test", ">= 0.6.3"