mirror of https://github.com/rails/rails
Merge pull request #6668 from pomnikita/master
Compact array of values added to PermissionSet instance
This commit is contained in:
commit
41d63710f2
|
@ -5,7 +5,7 @@ module ActiveModel
|
|||
class PermissionSet < Set
|
||||
|
||||
def +(values)
|
||||
super(values.map(&:to_s))
|
||||
super(values.compact.map(&:to_s))
|
||||
end
|
||||
|
||||
def include?(key)
|
||||
|
|
|
@ -13,6 +13,12 @@ class PermissionSetTest < ActiveModel::TestCase
|
|||
assert new_list.include?('admin'), "did not add collection to #{@permission_list.inspect}}"
|
||||
end
|
||||
|
||||
test "+ compacts added collection values" do
|
||||
added_collection = [ nil ]
|
||||
new_list = @permission_list + added_collection
|
||||
assert_equal new_list, @permission_list, "did not add collection to #{@permission_list.inspect}}"
|
||||
end
|
||||
|
||||
test "include? normalizes multi-parameter keys" do
|
||||
multi_param_key = 'admin(1)'
|
||||
new_list = @permission_list += [ 'admin' ]
|
||||
|
|
Loading…
Reference in New Issue