mirrors
/
rails
mirror of https://github.com/rails/rails
8
0
Fork 0
Code Issues Projects Releases Wiki Activity

Pin minitest version to 5.21 

Managed to reproduce CI failure at https://buildkite.com/rails/rails-nightly/builds/133#018d7bb8-8a32-4978-8e36-d7cb9b067813/1196-1204 . It would also reproduce against the released versions of Ruby because this is triggered by minitest v5.22.0 change. ebb468c81c

To avoid all of railties CI failures, pin minitest version to 5.21 tentatively.

* Steps to reproduce
```ruby
git clone https://github.com/rails/rails
cd rails
rm Gemfile.lock
bundle install
cd railties
bin/test test/application/test_runner_test.rb -n test_system_tests_are_not_run_with_the_default_test_command
```

* Expected behavior
It should pass.

* Actual behavior
```ruby
$ bin/test test/application/test_runner_test.rb -n test_system_tests_are_not_run_with_the_default_test_command
Run options: -n test_system_tests_are_not_run_with_the_default_test_command --seed 14574

F

Failure:
ApplicationTests::TestRunnerTest#test_system_tests_are_not_run_with_the_default_test_command [test/application/test_runner_test.rb:1191]:
Expected /0\ runs,\ 0\ assertions,\ 0\ failures,\ 0\ errors,\ 0\ skips/ to match "Nothing ran for filter: \nRunning 0 tests in a single process (parallelization threshold is 50)\nRun options: --seed 45713\n\n# Running:\n\n".

bin/test test/application/test_runner_test.rb:1179

Finished in 9.982314s, 0.1002 runs/s, 0.2004 assertions/s.
1 runs, 2 assertions, 1 failures, 0 errors, 0 skips
$
```
This commit is contained in:
Yasuo Honda 2024-02-06 09:59:36 +09:00
parent f14401aa17
commit 0c9329161c
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Gemfile
View File

@ -3,7 +3,7 @@
source "https://rubygems.org" source "https://rubygems.org"
gemspec gemspec
gem "minitest", ">= 5.15.0" gem "minitest", ">= 5.15.0", "< 5.22.0"
# We need a newish Rake since Active Job sets its test tasks' descriptions. # We need a newish Rake since Active Job sets its test tasks' descriptions.
gem "rake", ">= 13" gem "rake", ">= 13"

4
Gemfile.lock
View File

@ -93,7 +93,7 @@ PATH
connection_pool (>= 2.2.5) connection_pool (>= 2.2.5)
drb drb
i18n (>= 1.6, < 2) i18n (>= 1.6, < 2)
minitest (>= 5.1) minitest (>= 5.1, < 5.22.0)
tzinfo (~> 2.0, >= 2.0.5) tzinfo (~> 2.0, >= 2.0.5)
rails (7.2.0.alpha) rails (7.2.0.alpha)
actioncable (= 7.2.0.alpha) actioncable (= 7.2.0.alpha)
@ -618,7 +618,7 @@ DEPENDENCIES
libxml-ruby libxml-ruby
listen (~> 3.3) listen (~> 3.3)
mdl (!= 0.13.0) mdl (!= 0.13.0)
minitest (>= 5.15.0) minitest (>= 5.15.0, < 5.22.0)
minitest-bisect minitest-bisect
minitest-ci minitest-ci
minitest-retry minitest-retry

2
activesupport/activesupport.gemspec
View File

@ -38,7 +38,7 @@ Gem::Specification.new do |s|
s.add_dependency "tzinfo", "~> 2.0", ">= 2.0.5" s.add_dependency "tzinfo", "~> 2.0", ">= 2.0.5"
s.add_dependency "concurrent-ruby", "~> 1.0", ">= 1.0.2" s.add_dependency "concurrent-ruby", "~> 1.0", ">= 1.0.2"
s.add_dependency "connection_pool", ">= 2.2.5" s.add_dependency "connection_pool", ">= 2.2.5"
s.add_dependency "minitest", ">= 5.1" s.add_dependency "minitest", ">= 5.1", "< 5.22.0"
s.add_dependency "base64" s.add_dependency "base64"
s.add_dependency "drb" s.add_dependency "drb"
s.add_dependency "bigdecimal" s.add_dependency "bigdecimal"