From 446dea7ba02147212f9e6c7d877ea1a1e2053fec Mon Sep 17 00:00:00 2001
From: Ben Balter <ben.balter@github.com>
Date: Thu, 22 Jun 2017 12:18:31 -0400
Subject: [PATCH] refactor bin

---
 bin/licensee     | 33 ++++++++++++++++++++++++++++-----
 spec/bin_spec.rb |  4 ++--
 2 files changed, 30 insertions(+), 7 deletions(-)

diff --git a/bin/licensee b/bin/licensee
index 07015c9..720efc2 100755
--- a/bin/licensee
+++ b/bin/licensee
@@ -8,6 +8,27 @@ def format_percent(float)
   "#{format('%.2f', float)}%"
 end
 
+# Given a string or object, prepares it for output and human consumption
+def humanize(value, type = nil)
+  case type
+  when :license
+    value.name
+  when :matcher
+    value.class
+  when :confidence
+    format_percent(value)
+  when :method
+    value.to_s.gsub('_', ' ').capitalize
+  else
+    value
+  end
+end
+
+# Methods to call when displaying information about ProjectFiles
+MATCHED_FILE_METHODS = %i(
+  content_hash attribution confidence matcher license
+)
+
 project = Licensee.project(path, detect_packages: true, detect_readme: true)
 
 if project.license
@@ -22,11 +43,13 @@ puts "Matched files: #{project.matched_files.map(&:filename)}"
 
 project.matched_files.each do |matched_file|
   puts "#{matched_file.filename}:"
-  puts "  Content Hash: #{matched_file.content_hash}" if matched_file.respond_to?(:content_hash)
-  puts "  Attribution: #{matched_file.attribution}" if matched_file.respond_to?(:attribution)
-  puts "  License: #{matched_file.license.name}" if matched_file.license
-  puts "  Confidence: #{format_percent(matched_file.confidence)}"
-  puts "  Method: #{matched_file.matcher.class}" if matched_file.matcher
+
+  MATCHED_FILE_METHODS.each do |method|
+    next unless matched_file.respond_to? method
+    value = matched_file.public_send method
+    next if value.nil?
+    puts "  #{humanize(method, :method)}: #{humanize(value, method)}"
+  end
 
   if matched_file.is_a?(Licensee::Project::LicenseFile) && matched_file.confidence != 100
     matcher = Licensee::Matchers::Dice.new(matched_file)
diff --git a/spec/bin_spec.rb b/spec/bin_spec.rb
index 334a5a5..12f12b6 100644
--- a/spec/bin_spec.rb
+++ b/spec/bin_spec.rb
@@ -34,8 +34,8 @@ RSpec.describe 'command line invocation' do
     end
 
     it 'outputs the method' do
-      expect(stdout).to match('Method: Licensee::Matchers::Exact')
-      expect(stdout).to match('Method: Licensee::Matchers::Gemspec')
+      expect(stdout).to match('Matcher: Licensee::Matchers::Exact')
+      expect(stdout).to match('Matcher: Licensee::Matchers::Gemspec')
     end
 
     it 'outputs the matched files' do