From 3cf661352a32d73ba829490336e0f47be0b7a785 Mon Sep 17 00:00:00 2001
From: yeyunpeng2020 <yeyunpeng1@huawei.com>
Date: Thu, 28 Apr 2022 14:39:22 +0800
Subject: [PATCH] fix security function

---
 mindspore/lite/tools/converter/converter.cc       | 3 +++
 mindspore/lite/tools/converter/converter_flags.cc | 6 ------
 mindspore/lite/tools/converter/converter_flags.h  | 2 +-
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/mindspore/lite/tools/converter/converter.cc b/mindspore/lite/tools/converter/converter.cc
index d9b9d8e8c39..bbea7d7c187 100644
--- a/mindspore/lite/tools/converter/converter.cc
+++ b/mindspore/lite/tools/converter/converter.cc
@@ -371,9 +371,12 @@ int RunConverter(int argc, const char **argv) {
     }
   }
   // clear key
+  flags->dec_key.clear();
+  flags->encKeyStr.clear();
   status = memset_s(flags->encKey, converter::kEncMaxLen, 0, converter::kEncMaxLen);
   if (status != EOK) {
     MS_LOG(ERROR) << "memset failed.";
+    delete meta_graph;
     return RET_ERROR;
   }
   delete meta_graph;
diff --git a/mindspore/lite/tools/converter/converter_flags.cc b/mindspore/lite/tools/converter/converter_flags.cc
index a5158e0c341..9cd677d3a70 100644
--- a/mindspore/lite/tools/converter/converter_flags.cc
+++ b/mindspore/lite/tools/converter/converter_flags.cc
@@ -527,12 +527,6 @@ int Flags::Init(int argc, const char **argv) {
   return RET_OK;
 }
 
-Flags::~Flags() {
-  dec_key.clear();
-  encKeyStr.clear();
-  memset(encKey, 0, kEncMaxLen);
-}
-
 bool CheckOfflineParallelConfig(const std::string &file, ParallelSplitConfig *parallel_split_config) {
   // device: [device0 device1] ---> {cpu, gpu}
   // computeRate: [x: y] x >=0 && y >=0 && x/y < 10
diff --git a/mindspore/lite/tools/converter/converter_flags.h b/mindspore/lite/tools/converter/converter_flags.h
index 8651ff6ad22..e0a4a9bf5da 100644
--- a/mindspore/lite/tools/converter/converter_flags.h
+++ b/mindspore/lite/tools/converter/converter_flags.h
@@ -51,7 +51,7 @@ class Flags : public virtual mindspore::lite::FlagParser {
  public:
   Flags();
 
-  ~Flags() override;
+  ~Flags() = default;
 
   int InitInputOutputDataType();