react/packages/react-noop-renderer
Brian Vaughn 9faf389e79 Reset profiler timer correctly after errors (#13123)
* Reset ReactProfilerTimer's DEV-only Fiber stack after an error

* Added ReactNoop functionality to error during "complete" phase

* Added failing profiler stack unwinding test

* Potential fix for unwinding time bug

* Renamed test

* Don't record time until complete phase succeeds. Simplifies unwinding.

* Expanded ReactProfilerDevToolsIntegration-test coverage a bit

* Added unstable_flushWithoutCommitting method to noop renderer

* Added failing multi-root/batch test to ReactProfiler-test

* Beefed up tests a bit and added some TODOs

* Profiler timer differentiates between batched commits and in-progress async work

This was a two-part change:
1) Don't count time spent working on a batched commit against yielded async work.
2) Don't assert an empty stack after processing a batched commit (because there may be yielded async work)

This is kind of a hacky solution, and may have problems that I haven't thought of yet. I need to commit this so I can mentally clock out for a bit without worrying about it. I will think about it more when I'm back from PTO. In the meanwhile, input is welcome.

* Removed TODO

* Replaced FiberRoot map with boolean

* Removed unnecessary whitespace edit
2018-07-05 11:38:06 -07:00
..
npm Split ReactNoop into normal and persistent exports (#12793) 2018-05-14 13:57:33 +01:00
src Reset profiler timer correctly after errors (#13123) 2018-07-05 11:38:06 -07:00
README.md Add Fiber Debugger (#8033) 2016-10-25 08:36:37 +01:00
index.js Remove vars (#11766) 2017-12-05 13:47:57 +00:00
package.json Remove transitive dependency on fbjs (#13075) 2018-06-19 17:52:37 +01:00
persistent.js Split ReactNoop into normal and persistent exports (#12793) 2018-05-14 13:57:33 +01:00

README.md

react-noop-renderer

This package is the renderer we use for debugging Fiber. It is not intended to be used directly.