af219cc6e6
* Lint rule to forbid access of cross-fork fields
We use a shared Fiber type for both reconciler forks (old and new). It
is a superset of all the fields used by both forks. However, there are
some fields that should only be used in the new fork, and others that
should only be used in the old fork.
Ideally we would enforce this with separate Flow types for each fork.
The problem is that the Fiber type is accessed by some packages outside
the reconciler (like React DOM), and get passed into the reconciler as
arguments. So there's no way to fork the Fiber type without also forking
the packages where they are used. FiberRoot has the same issue.
Instead, I've added a lint rule that forbids cross-fork access of
fork-specific fields. Fields that end in `_old` or `_new` are forbidden
from being used inside the new or old fork respectively. Or you can
specific custom fields using the ESLint plugin options.
I used this plugin to find and remove references to the effect list
in
|
||
|---|---|---|
| .. | ||
| __tests__ | ||
| README.md | ||
| index.js | ||
| invariant-args.js | ||
| no-cross-fork-imports.js | ||
| no-cross-fork-types.js | ||
| no-primitive-constructors.js | ||
| no-production-logging.js | ||
| no-to-warn-dev-within-to-throw.js | ||
| package.json | ||
| warning-args.js | ||
README.md
Custom ESLint Rules
This is a dummy npm package that allows us to treat it as an eslint-plugin. It's not actually published, nor are the rules here useful for users of React. If you want to lint your React code, try https://github.com/yannickcr/eslint-plugin-react.
If you modify this rule, you must re-run npm install ./eslint-rules for it to take effect.