maxjhandsome
/
react
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
react/packages/shared/isTextInputElement.js

46 lines
974 B
JavaScript
Raw Normal View History

Fix SelectEventPlugin There were 2 issues: I was reusing event outside the original event handler (activeNativeEvent). This is a bad idea. I've changed deferred dispatch to have an empty object as the nativeEvent. I didn't handle inputs without .selectionStart (e.g. file inputs). I extracted a input type check from ChangeEventPlugin and reuse it here.
2013-10-09 01:26:51 +08:00
/**
Drop the year from Facebook copyright headers and the LICENSE file. (#13593)
2018-09-08 06:11:23 +08:00
* Copyright (c) Facebook, Inc. and its affiliates.
Fix SelectEventPlugin There were 2 issues: I was reusing event outside the original event handler (activeNativeEvent). This is a bad idea. I've changed deferred dispatch to have an empty object as the nativeEvent. I didn't handle inputs without .selectionStart (e.g. file inputs). I extracted a input type check from ChangeEventPlugin and reuse it here.
2013-10-09 01:26:51 +08:00
*
Update license headers BSD+Patents -> MIT Did find and replace in TextMate. ``` find: (?:( \*)( ))?Copyright (?:\(c\) )?(\d{4})\b.+Facebook[\s\S]+(?:this source tree|the same directory)\.$ replace: $1$2Copyright (c) $3-present, Facebook, Inc.\n$1\n$1$2This source code is licensed under the MIT license found in the\n$1$2LICENSE file in the root directory of this source tree. ```
2017-09-25 04:48:13 +08:00
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
Fix SelectEventPlugin There were 2 issues: I was reusing event outside the original event handler (activeNativeEvent). This is a bad idea. I've changed deferred dispatch to have an empty object as the nativeEvent. I didn't handle inputs without .selectionStart (e.g. file inputs). I extracted a input type check from ChangeEventPlugin and reuse it here.
2013-10-09 01:26:51 +08:00
*
[flow] isTextInputElement (#7075) Summary: I had to cast into any because flow doesn't think that checking the lowercase version of nodeName is a valid way to refine the variable from HTMLElement to HTMLInputElement. I'm also not confident enough in changing the implementation to an instanceof HTMLInputElement to please flow. It also takes care of the null check in the process. The `nodeName &&` condition wasn't useful since the two branches are checking it against concrete values and actually makes the type different since nodeName is not a boolean per se. I replaced them with if conditions to make it clearer what it actually did instead of doing boolean logic tricks. It is unclear why I had to type supportedInputTypes, see this internal post for a discussion: https://www.facebook.com/groups/flowtype/permalink/1084168611631753/ The only difference in behavior is that I now explicitely convert to boolean the object dereference via `!!`. Test Plan: npm run flow Careful inspection of the code Reviewers: @zpao @spicyj
2016-07-06 01:22:56 +08:00
* @flow
Fix SelectEventPlugin There were 2 issues: I was reusing event outside the original event handler (activeNativeEvent). This is a bad idea. I've changed deferred dispatch to have an empty object as the nativeEvent. I didn't handle inputs without .selectionStart (e.g. file inputs). I extracted a input type check from ChangeEventPlugin and reuse it here.
2013-10-09 01:26:51 +08:00
*/
/**
Fix lines longer than 80 chars
2014-01-15 20:47:16 +08:00
* @see http://www.whatwg.org/specs/web-apps/current-work/multipage/the-input-element.html#input-type-attr-summary
Fix SelectEventPlugin There were 2 issues: I was reusing event outside the original event handler (activeNativeEvent). This is a bad idea. I've changed deferred dispatch to have an empty object as the nativeEvent. I didn't handle inputs without .selectionStart (e.g. file inputs). I extracted a input type check from ChangeEventPlugin and reuse it here.
2013-10-09 01:26:51 +08:00
*/
shared: convert vars into let/const (#11730)
2017-12-01 08:03:27 +08:00
const supportedInputTypes: {[key: string]: true | void} = {
Run prettier
2017-03-14 08:05:18 +08:00
color: true,
date: true,
datetime: true,
Fix SelectEventPlugin There were 2 issues: I was reusing event outside the original event handler (activeNativeEvent). This is a bad idea. I've changed deferred dispatch to have an empty object as the nativeEvent. I didn't handle inputs without .selectionStart (e.g. file inputs). I extracted a input type check from ChangeEventPlugin and reuse it here.
2013-10-09 01:26:51 +08:00
'datetime-local': true,
Run prettier
2017-03-14 08:05:18 +08:00
email: true,
month: true,
number: true,
password: true,
range: true,
search: true,
tel: true,
text: true,
time: true,
url: true,
week: true,
Fix SelectEventPlugin There were 2 issues: I was reusing event outside the original event handler (activeNativeEvent). This is a bad idea. I've changed deferred dispatch to have an empty object as the nativeEvent. I didn't handle inputs without .selectionStart (e.g. file inputs). I extracted a input type check from ChangeEventPlugin and reuse it here.
2013-10-09 01:26:51 +08:00
};
Flow: bool -> boolean (#7650)
2016-09-03 08:35:14 +08:00
function isTextInputElement(elem: ?HTMLElement): boolean {
shared: convert vars into let/const (#11730)
2017-12-01 08:03:27 +08:00
const nodeName = elem && elem.nodeName && elem.nodeName.toLowerCase();
[flow] isTextInputElement (#7075) Summary: I had to cast into any because flow doesn't think that checking the lowercase version of nodeName is a valid way to refine the variable from HTMLElement to HTMLInputElement. I'm also not confident enough in changing the implementation to an instanceof HTMLInputElement to please flow. It also takes care of the null check in the process. The `nodeName &&` condition wasn't useful since the two branches are checking it against concrete values and actually makes the type different since nodeName is not a boolean per se. I replaced them with if conditions to make it clearer what it actually did instead of doing boolean logic tricks. It is unclear why I had to type supportedInputTypes, see this internal post for a discussion: https://www.facebook.com/groups/flowtype/permalink/1084168611631753/ The only difference in behavior is that I now explicitely convert to boolean the object dereference via `!!`. Test Plan: npm run flow Careful inspection of the code Reviewers: @zpao @spicyj
2016-07-06 01:22:56 +08:00
if (nodeName === 'input') {
return !!supportedInputTypes[((elem: any): HTMLInputElement).type];
}
if (nodeName === 'textarea') {
return true;
}
return false;
Fix SelectEventPlugin There were 2 issues: I was reusing event outside the original event handler (activeNativeEvent). This is a bad idea. I've changed deferred dispatch to have an empty object as the nativeEvent. I didn't handle inputs without .selectionStart (e.g. file inputs). I extracted a input type check from ChangeEventPlugin and reuse it here.
2013-10-09 01:26:51 +08:00
}
Convert the Source to ES Modules (#11389) * Update transforms to handle ES modules * Update Jest to handle ES modules * Convert react package to ES modules * Convert react-art package to ES Modules * Convert react-call-return package to ES Modules * Convert react-test-renderer package to ES Modules * Convert react-cs-renderer package to ES Modules * Convert react-rt-renderer package to ES Modules * Convert react-noop-renderer package to ES Modules * Convert react-dom/server to ES modules * Convert react-dom/{client,events,test-utils} to ES modules * Convert react-dom/shared to ES modules * Convert react-native-renderer to ES modules * Convert react-reconciler to ES modules * Convert events to ES modules * Convert shared to ES modules * Remove CommonJS support from transforms * Move ReactDOMFB entry point code into react-dom/src This is clearer because we can use ES imports in it. * Fix Rollup shim configuration to work with ESM * Fix incorrect comment * Exclude external imports without side effects * Fix ReactDOM FB build * Remove TODOs I don’t intend to fix yet
2017-11-03 03:50:03 +08:00
export default isTextInputElement;