forked from OSchip/llvm-project
4f9a5c2a14
No intended behavior change. EmitGCCInlineAsmStr() used to explicitly check for modifier 'l' after handling block address and machine basic block operands. This prevented passing a MachineOperand with 'l' modifier to PrintAsmMemoryOperand(). Conceptually that seems kind of nice, but in practice the overrides of PrintAsmMemoryOperand() in all (*) AsmPrinter subclasses already reject modifiers they don't know about, and none of them don't know about 'l'. So removing this doesn't have a behavior difference, is less code, and it makes EmitGCCInlineAsmStr() and EmitMSInlineAsmStr() more similar, to prepare for merging them later. (Why not _add_ the branch to EmitMSInlineAsmStr() instead? Because that always works with X86AsmPrinter I think, and X86AsmPrinter::PrintAsmMemoryOperand() very decisively rejects the 'l' modifier, so it's hard to motivate adding that branch.) *: The one exception was AVRAsmPrinter, which had an llvm_unreachable instead of returning true. So this commit changes that, so that the AVR target keeps emitting an error instead of crashing when passing a mem operand with a :l modifier to it. All the other targets already don't crash on this. Differential Revision: https://reviews.llvm.org/D114216 |
||
|---|---|---|
| .. | ||
| AsmParser | ||
| Disassembler | ||
| MCTargetDesc | ||
| TargetInfo | ||
| AVR.h | ||
| AVR.td | ||
| AVRAsmPrinter.cpp | ||
| AVRCallingConv.td | ||
| AVRDevices.td | ||
| AVRExpandPseudoInsts.cpp | ||
| AVRFrameLowering.cpp | ||
| AVRFrameLowering.h | ||
| AVRISelDAGToDAG.cpp | ||
| AVRISelLowering.cpp | ||
| AVRISelLowering.h | ||
| AVRInstrFormats.td | ||
| AVRInstrInfo.cpp | ||
| AVRInstrInfo.h | ||
| AVRInstrInfo.td | ||
| AVRMCInstLower.cpp | ||
| AVRMCInstLower.h | ||
| AVRMachineFunctionInfo.h | ||
| AVRRegisterInfo.cpp | ||
| AVRRegisterInfo.h | ||
| AVRRegisterInfo.td | ||
| AVRRelaxMemOperations.cpp | ||
| AVRSelectionDAGInfo.h | ||
| AVRShiftExpand.cpp | ||
| AVRSubtarget.cpp | ||
| AVRSubtarget.h | ||
| AVRTargetMachine.cpp | ||
| AVRTargetMachine.h | ||
| AVRTargetObjectFile.cpp | ||
| AVRTargetObjectFile.h | ||
| CMakeLists.txt | ||
| README.md | ||
| TODO.md | ||