forked from OSchip/llvm-project
cd01430ff1
This fixes a bug with string merging with string symbols that contain NULLs, as is the case in the `merge-string.s` test. The bug only showed when we run with `--relocatable` and then try read the resulting object back in. In this case we would end up with string symbols that extend past the end of the segment in which they live. The problem comes from the fact that sections which are flagged as string mergable assume that all strings are NULL terminated. The merging algorithm will drop trailing chars that follow a NULL since they are essentially unreachable. However, the "size" attribute (in the symbol table) of such a truncated symbol is not updated resulting a symbol size that can overlap the end of the segment. I verified that this can happen in ELF too given the right conditions and the its harmless enough. In practice Strings that contain embedded null should not be part of a mergable section. Differential Revision: https://reviews.llvm.org/D102281 |
||
|---|---|---|
| .. | ||
| Archive.cpp | ||
| ArchiveWriter.cpp | ||
| Binary.cpp | ||
| CMakeLists.txt | ||
| COFFImportFile.cpp | ||
| COFFModuleDefinition.cpp | ||
| COFFObjectFile.cpp | ||
| Decompressor.cpp | ||
| ELF.cpp | ||
| ELFObjectFile.cpp | ||
| Error.cpp | ||
| FaultMapParser.cpp | ||
| IRObjectFile.cpp | ||
| IRSymtab.cpp | ||
| MachOObjectFile.cpp | ||
| MachOUniversal.cpp | ||
| MachOUniversalWriter.cpp | ||
| Minidump.cpp | ||
| ModuleSymbolTable.cpp | ||
| Object.cpp | ||
| ObjectFile.cpp | ||
| RecordStreamer.cpp | ||
| RecordStreamer.h | ||
| RelocationResolver.cpp | ||
| SymbolSize.cpp | ||
| SymbolicFile.cpp | ||
| TapiFile.cpp | ||
| TapiUniversal.cpp | ||
| WasmObjectFile.cpp | ||
| WindowsMachineFlag.cpp | ||
| WindowsResource.cpp | ||
| XCOFFObjectFile.cpp | ||