llvm-project/polly/lib
David Peixotto a4817871d2 Safely generate new loop metadata node
Polly was accidently modifying a debug info metadata node when
attempting to generate a new unique metadata node for the loop id.
The problem was that we had dwarf metadata that referred to a
metadata node with a null value, like this:

  !6 = ... some dwarf metadata referring to !7 ...
  !7 = {null}

When we attempt to generate a new metadata node, we reserve the
first space for self-referential node by setting the first argument
to null and then mutating the node later to refer to itself.
However, because the nodes are uniqued based on pointer values, when
we get the new metadata node it actually referred to an existing
node (!7 in the example).  When we went to modify the metadata to
point to itself, we were accidently mutating the dwarf metatdata. We
ended up in this situation:

  !6 = ... some dwarf metadata referring to !7 ...
  !7 = {!7}

and this causes an assert when generating the debug info. The fix is
simple, we just need to use a unique value when getting a new
metadata node. The MDNode::getTemporary() provides exactly the API
we need (and it is used in clang to generate the unique nodes).

Differential Revision: http://reviews.llvm.org/D6174

llvm-svn: 221550
2014-11-07 21:44:18 +00:00
..
Analysis [Refactor][NFC] Generalize the creation of ScopArrayInfo objects. 2014-11-07 08:31:31 +00:00
CodeGen Safely generate new loop metadata node 2014-11-07 21:44:18 +00:00
Exchange [Refactor][NfC] Simplify and clean the handling of (new) access relations 2014-10-13 12:58:03 +00:00
JSON Added arcanist linters and cleaned errors and warnings 2014-08-18 00:40:13 +00:00
Support [Refactor][NFC] Generalize the creation of ScopArrayInfo objects. 2014-11-07 08:31:31 +00:00
Transform Use stringFromIslObj instead of isl_..._dump to print to dbgs() 2014-10-22 23:16:28 +00:00
CMakeLists.txt [Polly] Remove the PoCC and ScopLib support 2014-08-13 17:49:16 +00:00
Makefile [Polly] Remove the PoCC and ScopLib support 2014-08-13 17:49:16 +00:00
Polly.cpp Move Pass registration into polly library 2014-03-19 17:54:23 +00:00