forked from OSchip/llvm-project
f425292721
Without any loops, we don't even bother to build the standard analyses used by loop passes. Without these, we can't run loop analyses or invalidate them properly. Unfortunately, we did these things in the wrong order which would allow a loop analysis manager's proxy to be built but then not have the standard analyses built. When we went to do the invalidation in the proxy thing would fall apart. In the test case provided, it would actually crash. The fix is to carefully check for loops first, and to in fact build the standard analyses before building the proxy. This allows it to correctly trigger invalidation for those standard analyses. An alternative might seem to be to look at whether there are any loops when doing invalidation, but this doesn't work when during the loop pipeline run we delete the last loop. I've even included that as a test case. It is both simpler and more robust to defer building the proxy until there are definitely the standard set of analyses and indeed loops. This bug was uncovered by enabling GlobalsAA in the pipeline. llvm-svn: 294728 |
||
|---|---|---|
| .. | ||
| Inputs | ||
| X86 | ||
| 2002-01-31-CallGraph.ll | ||
| 2002-02-24-InlineBrokePHINodes.ll | ||
| 2002-03-11-ConstPropCrash.ll | ||
| 2003-02-19-LoopInfoNestingBug.ll | ||
| 2004-08-16-PackedConstantInlineStore.ll | ||
| 2004-08-16-PackedGlobalConstant.ll | ||
| 2004-08-16-PackedSelect.ll | ||
| 2004-08-16-PackedSimple.ll | ||
| 2004-08-20-PackedControlFlow.ll | ||
| 2006-02-05-PassManager.ll | ||
| 2007-04-24-eliminate-mostly-empty-blocks.ll | ||
| 2007-06-05-PassID.ll | ||
| 2007-06-28-PassManager.ll | ||
| 2007-09-10-PassManager.ll | ||
| 2008-02-14-PassManager.ll | ||
| 2008-06-04-FieldSizeInPacked.ll | ||
| 2008-10-06-RemoveDeadPass.ll | ||
| 2008-10-15-MissingSpace.ll | ||
| 2009-03-31-CallGraph.ll | ||
| 2009-06-05-no-implicit-float.ll | ||
| 2009-09-14-function-elements.ll | ||
| 2010-05-06-Printer.ll | ||
| FileCheck-space.txt | ||
| ResponseFile.ll | ||
| attribute-comment.ll | ||
| bcanalyzer-block-info.txt | ||
| can-execute.txt | ||
| cgscc-devirt-iteration.ll | ||
| cgscc-iterate-function-mutation.ll | ||
| cgscc-observe-devirt.ll | ||
| cleanup-lcssa.ll | ||
| close-stderr.ll | ||
| constant-fold-gep-address-spaces.ll | ||
| constant-fold-gep.ll | ||
| extract-alias.ll | ||
| extract-linkonce.ll | ||
| extract-weak-odr.ll | ||
| extract.ll | ||
| invalid-commandline-option.ll | ||
| lint.ll | ||
| lit-quoting.txt | ||
| lit-unicode.txt | ||
| llvm-nm-without-aliases.ll | ||
| loop-pass-ordering.ll | ||
| loop-pm-invalidation.ll | ||
| new-pass-manager.ll | ||
| new-pm-defaults.ll | ||
| new-pm-lto-defaults.ll | ||
| opt-bisect-helper.py | ||
| opt-bisect-legacy-pass-manager.ll | ||
| opt-override-mcpu-mattr.ll | ||
| opt-twice.ll | ||
| optimization-remarks-inline.ll | ||
| optimization-remarks-invalidation.ll | ||
| optimization-remarks-lazy-bfi.ll | ||
| optimize-options.ll | ||
| pass-pipeline-parsing.ll | ||
| pass-pipelines.ll | ||
| pipefail.txt | ||
| spir_cc.ll | ||
| statistic.ll | ||
| umask.ll | ||