llvm-project/lldb/source
Pavel Labath fc89bbcc71 Unify PlatformPOSIX::ResolveExecutable
Summary:
various platforms very using nearly identical code for this method. As far as I
can tell there was nothing platform-specific about the differences, but rather
it looked like it was caused by tiny tweaks being made to individual copies
without affecting the overall functionality. I have taken the superset of all
these tweaks and put it into one method in the base class (incidentaly, nobody
was using the base class implementation of the method, as all classes were
overriding it). From the darwin class I took the slightly improved error
reporting (checking whether the file is readable) and the
ResolveExecutableInBundle call (which has no effect elsewhere as the function
is already a no-op on non-darwin platforms). From the linux class I took the
set-the-triple-vendor-to-host-if-unspecified tweak (present in PlatformKalimba
as well).

PlatformWindows has an identical copy as well. We could resolve that by pushing
this code further down into Platform class, that that would require pushing the
m_remote_platform_sp member as well, which seems like a bad design choice.

Reviewers: clayborg, emaste, krytarowski

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D29406

llvm-svn: 293910
2017-02-02 17:50:03 +00:00
..
API Add logging to SBThread::GetInfoItemByPathAsString to 2017-02-02 03:02:51 +00:00
Breakpoint [CMake] Add accurate dependency specifications 2017-01-31 20:43:05 +00:00
Commands Break some dependencies in lldbUtility. 2017-02-01 19:45:14 +00:00
Core Break some dependencies in lldbUtility. 2017-02-01 19:45:14 +00:00
DataFormatters [CMake] Add accurate dependency specifications 2017-01-31 20:43:05 +00:00
Expression [CMake] Add accurate dependency specifications 2017-01-31 20:43:05 +00:00
Host Fix android build of the new process launcher 2017-02-01 16:43:22 +00:00
Initialization [CMake] Add accurate dependency specifications 2017-01-31 20:43:05 +00:00
Interpreter Break some dependencies in lldbUtility. 2017-02-01 19:45:14 +00:00
Plugins Unify PlatformPOSIX::ResolveExecutable 2017-02-02 17:50:03 +00:00
Symbol [CMake] Add accurate dependency specifications 2017-01-31 20:43:05 +00:00
Target Break some dependencies in lldbUtility. 2017-02-01 19:45:14 +00:00
Utility Break some dependencies in lldbUtility. 2017-02-01 19:45:14 +00:00
CMakeLists.txt [CMake] Fixing CMake to append source properties instead of overwrite them. 2016-11-10 23:56:32 +00:00
lldb.cpp One more cleanup to lldb version printing 2016-11-14 22:43:08 +00:00