forked from OSchip/llvm-project
ed29dbaafa
This patch kills off a significant user of the "IsIndirect" field of DBG_VALUE machine insts. Brought up in in PR41675, IsIndirect is techncally redundant as it can be expressed by the DIExpression of a DBG_VALUE inst, and it isn't helpful to have two ways of expressing things. Rather than setting IsIndirect, have DBG_VALUE creators add an extra deref to the insts DIExpression. There should now be no appearences of IsIndirect=True from isel down to LiveDebugVariables / VirtRegRewriter, which is ensured by an assertion in LDVImpl::handleDebugValue. This means we also get to delete the IsIndirect handling in LiveDebugVariables. Tests can be upgraded by for example swapping the following IsIndirect=True DBG_VALUE: DBG_VALUE $somereg, 0, !123, !DIExpression(DW_OP_foo) With one where the indirection is in the DIExpression, by _appending_ a deref: DBG_VALUE $somereg, $noreg, !123, !DIExpression(DW_OP_foo, DW_OP_deref) Which both mean the same thing. Most of the test changes in this patch are updates of that form; also some changes in how the textual assembly printer handles these insts. Differential Revision: https://reviews.llvm.org/D68945 llvm-svn: 374877 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| CSEInfo.cpp | ||
| CSEMIRBuilder.cpp | ||
| CallLowering.cpp | ||
| Combiner.cpp | ||
| CombinerHelper.cpp | ||
| GISelChangeObserver.cpp | ||
| GISelKnownBits.cpp | ||
| GlobalISel.cpp | ||
| IRTranslator.cpp | ||
| InstructionSelect.cpp | ||
| InstructionSelector.cpp | ||
| LLVMBuild.txt | ||
| LegalityPredicates.cpp | ||
| LegalizeMutations.cpp | ||
| Legalizer.cpp | ||
| LegalizerHelper.cpp | ||
| LegalizerInfo.cpp | ||
| Localizer.cpp | ||
| MachineIRBuilder.cpp | ||
| RegBankSelect.cpp | ||
| RegisterBank.cpp | ||
| RegisterBankInfo.cpp | ||
| Utils.cpp | ||