forked from OSchip/llvm-project
c22c7b1459
Currently this code always makes 2 or 3 calls to tryFactorization regardless of whether the LHS/RHS are BinaryOperators. We make 3 calls when both operands are BinaryOperators with the same opcode. Or surprisingly, when neither are BinaryOperators. This is because getBinOpsForFactorization returns Instruction::BinaryOpsEnd when the operand is not a BinaryOperator. If both LHS and RHS are not BinaryOperators then they both have an Opcode of Instruction::BinaryOpsEnd. When this happens we rely on tryFactorization to early out due to A/B/C/D being null. Similar behavior occurs for the other calls, we rely on getBinOpsForFactorization having made A/B or C/D null to get tryFactorization to early out. We also rely on these null checks to check the result of getIdentityValue and early out for it. This patches refactors this to pull these checks up to SimplifyUsingDistributiveLaws so we don't rely on BinaryOpsEnd as a sentinel or this A/B/C/D null behavior. I think this makes this code easier to reason about. Should also give a tiny performance improvement for cases where the LHS or RHS isn't a BinaryOperator. Differential Revision: https://reviews.llvm.org/D31913 llvm-svn: 300353 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| InstCombineAddSub.cpp | ||
| InstCombineAndOrXor.cpp | ||
| InstCombineCalls.cpp | ||
| InstCombineCasts.cpp | ||
| InstCombineCompares.cpp | ||
| InstCombineInternal.h | ||
| InstCombineLoadStoreAlloca.cpp | ||
| InstCombineMulDivRem.cpp | ||
| InstCombinePHI.cpp | ||
| InstCombineSelect.cpp | ||
| InstCombineShifts.cpp | ||
| InstCombineSimplifyDemanded.cpp | ||
| InstCombineVectorOps.cpp | ||
| InstructionCombining.cpp | ||
| LLVMBuild.txt | ||