llvm-project/lldb
Pavel Labath f1208e7aef ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion
Summary:
These two functions were calling each other, while handling different
branches of the if(IsInMemory()). This had a reason at some point in the
past, but right now it's just confusing.

I resolve this by removing the MemoryMapSectionData function and
inlining the !IsInMemory branch into ReadSectionData. There isn't
anything mmap-related in this function anyway, as the decision whether
to mmap is handled at a higher level.

This is a preparatory step to make ObjectFileELF be able to decompress
compressed sections (I want to make sure that all calls reading section
data are routed through a single piece of code).

Reviewers: clayborg

Subscribers: emaste, JDevlieghere, lldb-commits

Differential Revision: https://reviews.llvm.org/D41169

llvm-svn: 320705
2017-12-14 14:56:45 +00:00
..
cmake [lldb] Set component when invoking add_llvm_install_targets 2017-12-13 01:14:27 +00:00
docs Adding Support for Error Strings in Remote Packets 2017-07-12 11:15:34 +00:00
examples Fixed up to use a class for the commands, renamed the commands and added a way to just dump the compile unit full paths and optionally their support files with the new "dump-files"command. 2017-11-16 17:14:48 +00:00
include/lldb ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion 2017-12-14 14:56:45 +00:00
lit [CMake] Build clang as dependency when using in-tree clang for tests. 2017-10-27 21:22:57 +00:00
lldb.xcodeproj Fix the gtest target for the move of ArchSpecTest.cpp from Core to Utility. 2017-11-30 00:23:42 +00:00
lldb.xcworkspace Revert r275223, which committed the wrong thing. 2016-07-12 23:31:42 +00:00
packages/Python/lldbsuite [TestModulesInlineFunctions] This test now passes. 2017-12-12 02:52:01 +00:00
resources Bump the lldb version # in the xcode project files from 2016-03-15 04:36:11 +00:00
scripts Revert r317182 for https://reviews.llvm.org/D39128 2017-11-02 03:17:07 +00:00
source ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion 2017-12-14 14:56:45 +00:00
test Add a dependency from check-lldb on lld 2017-11-06 19:25:33 +00:00
third_party/Python/module *** This commit represents a complete reformatting of the LLDB source code 2016-09-06 20:57:50 +00:00
tools Change uses of strncpy in debugserver to strlcpy 2017-12-09 03:37:09 +00:00
unittests Add a StringList constructor to Args class 2017-12-11 14:22:30 +00:00
utils *** This commit represents a complete reformatting of the LLDB source code 2016-09-06 20:57:50 +00:00
www Update remote debugging page with many more details. 2017-11-28 20:04:43 +00:00
.arcconfig Upgrade all the .arcconfigs to https. 2016-07-14 13:15:37 +00:00
.clang-format Updated .clang-format rules so bring LLDB in line with LLVM standards. 2016-09-06 17:19:00 +00:00
.gitignore test infra: clear file-charged issues on rerun of file 2016-10-01 00:17:08 +00:00
CMakeLists.txt Default to using in-tree clang for building test executables 2017-10-27 02:24:04 +00:00
CODE_OWNERS.txt Remove Sean Callanan from the CODE_OWNERS, he won't have time 2017-11-01 01:38:42 +00:00
INSTALL.txt Changed builld-llvm.py to use .json files 2017-02-23 02:21:34 +00:00
LICENSE.TXT
use_lldb_suite_root.py *** This commit represents a complete reformatting of the LLDB source code 2016-09-06 20:57:50 +00:00