llvm-project/lldb/source
Raphael Isemann 4f7fb13f87 [lldb] Don't save empty expressions in the multiline editor history
Right now running `expr` to start the multiline expression editor and then
pressing enter causes an empty history empty to be created for the multiline
editor. That doesn't seem very useful for users as pressing the 'up' key will
now also bring up these empty expressions.

I don't think there is ever a use case for recalling a completely empty
expression from the history, so instead don't save those entries to the history
file and make sure we never recall them when navigating over the expression
history.

Note: This is actually a Swift downstream patch that got shipped with Apple's
LLDB for many years. However, this recently started conflicting with upstream
LLDB as D100048 added a test that made sure that empty expression entries don't
crash LLDB. Apple's LLDB was never affected by this crash as it never saved
empty expressions in the first place.

Reviewed By: augusto2112

Differential Revision: https://reviews.llvm.org/D108983
2021-08-31 18:51:18 +02:00
..
API Revert "[lldb] Add minidump save-core functionality to ELF object files" 2021-08-31 13:36:53 +02:00
Breakpoint [lldb] Use a struct to pass function search options to Module::FindFunction 2021-08-05 10:18:14 -07:00
Commands Revert "[lldb] Add minidump save-core functionality to ELF object files" 2021-08-31 13:36:53 +02:00
Core Revert "[lldb] Add minidump save-core functionality to ELF object files" 2021-08-31 13:36:53 +02:00
DataFormatters [nfc] [lldb] Prevent needless copies of DataExtractor 2021-08-04 20:35:53 +02:00
Expression [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat 2021-08-09 12:06:59 +02:00
Host [lldb] Don't save empty expressions in the multiline editor history 2021-08-31 18:51:18 +02:00
Initialization [lldb] Replace default bodies of special member functions with = default; 2021-07-02 11:31:16 -07:00
Interpreter [lldb] [gdb-remote] Add eOpenOptionReadWrite for future gdb compat 2021-08-09 12:06:59 +02:00
Plugins [lldb] [gdb-remote client] Remove breakpoints in forked processes 2021-08-31 13:41:35 +02:00
Symbol [lldb] Return all line entries matchign a line if no column is specified 2021-08-30 14:45:46 +02:00
Target [lldb] [gdb-remote client] Support minimal fork/vfork handling 2021-08-30 10:24:38 +02:00
Utility [lldb][AArch64] Add memory tag writing to lldb-server 2021-07-27 12:02:17 +01:00
CMakeLists.txt Remove HAVE_VCS_VERSION_INC, not needed 2020-10-29 13:09:05 -07:00
lldb.cpp [lldb] Reinstate support for LLDB_VERSION_STRING 2021-02-22 16:56:00 -08:00