llvm-project/clang/lib/CodeGen
Sander de Smalen 17c4633e7f [DebugInfo] Enable debug information for C99 VLA types
Summary:
This patch enables debugging of C99 VLA types by generating more precise
LLVM Debug metadata, using the extended DISubrange 'count' field that
takes a DIVariable.
    
This should implement:
  Bug 30553: Debug info generated for arrays is not what GDB expects (not as good as GCC's)
https://bugs.llvm.org/show_bug.cgi?id=30553

Reviewers: echristo, aprantl, dexonsmith, clayborg, pcc, kristof.beyls, dblaikie

Reviewed By: aprantl

Subscribers: jholewinski, schweitz, davide, fhahn, JDevlieghere, cfe-commits

Differential Revision: https://reviews.llvm.org/D41698

llvm-svn: 323952
2018-02-01 11:25:10 +00:00
..
ABIInfo.h Refactor handling of signext/zeroext in ABIArgInfo 2018-01-12 20:08:16 +00:00
Address.h
BackendUtil.cpp NewPM: Improve/fix GCOV - which needs to run early in the pass pipeline. 2018-01-23 01:25:24 +00:00
CGAtomic.cpp [CodeGen] Decorate aggregate accesses with TBAA tags 2018-01-25 14:21:55 +00:00
CGBlocks.cpp [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CGBlocks.h
CGBuilder.h Change memcpy/memove/memset to have dest and source alignment attributes. 2018-01-28 17:27:45 +00:00
CGBuiltin.cpp IRGen: Emit an inline implementation of __builtin_wmemcmp on MSVCRT platforms. 2018-01-24 18:59:58 +00:00
CGCUDANV.cpp Suppress all uses of LLVM_END_WITH_NULL. NFC. 2017-05-09 19:31:30 +00:00
CGCUDARuntime.cpp Refactor call emission to package the function pointer together with 2016-10-26 23:46:34 +00:00
CGCUDARuntime.h
CGCXX.cpp [MS] Don't bail on replacing dllimport vbase dtors with base dtors 2017-10-13 00:53:02 +00:00
CGCXXABI.cpp [MS] Apply adjustments after storing 'this' 2017-11-16 19:09:36 +00:00
CGCXXABI.h IRGen: When performing CFI checks, load vtable pointer from vbase when necessary. 2017-12-13 21:53:04 +00:00
CGCall.cpp [CodeGen] Decorate aggregate accesses with TBAA tags 2018-01-25 14:21:55 +00:00
CGCall.h Use less temporary AttributeLists NFC 2017-04-18 23:50:03 +00:00
CGClass.cpp [CodeGen] Use the non-virtual alignment when emitting the base 2018-01-27 00:34:09 +00:00
CGCleanup.cpp Allocate and access NormalCleanupDest with the natural alignment of i32. 2018-01-12 22:07:01 +00:00
CGCleanup.h Use the correct ObjC EH personality 2017-01-08 22:58:07 +00:00
CGCoroutine.cpp [coroutines] Support coroutine-handle returning await-suspend (i.e symmetric control transfer) 2017-08-25 04:46:54 +00:00
CGDebugInfo.cpp [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CGDebugInfo.h [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CGDecl.cpp [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CGDeclCXX.cpp [OPENMP] Support for -fopenmp-simd option with compilation of simd loops 2017-12-29 18:07:07 +00:00
CGException.cpp [WinEH] Allow for multiple terminatepads 2018-01-02 21:34:16 +00:00
CGExpr.cpp [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CGExprAgg.cpp [CodeGen] Decorate aggregate accesses with TBAA tags 2018-01-25 14:21:55 +00:00
CGExprCXX.cpp [CodeGen] Decorate aggregate accesses with TBAA tags 2018-01-25 14:21:55 +00:00
CGExprComplex.cpp [Complex] Don't use __div?c3 when building with fast-math. 2017-12-20 15:50:52 +00:00
CGExprConstant.cpp [CodeGen][X86] Fix handling of __fp16 vectors. 2017-12-09 00:02:37 +00:00
CGExprScalar.cpp [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CGGPUBuiltin.cpp [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device. 2017-01-29 20:49:31 +00:00
CGLoopInfo.cpp [CodeGen] Pass objects that are expensive to copy by const ref. 2016-11-24 16:01:20 +00:00
CGLoopInfo.h [CodeGen] Pass objects that are expensive to copy by const ref. 2016-11-24 16:01:20 +00:00
CGObjC.cpp Revert "CodeGen: annotate ObjC ARC functions with ABI constraints" 2018-01-30 20:19:34 +00:00
CGObjCGNU.cpp Fix CGObjCGNU::init bug introduced by r302572 2017-05-09 21:19:44 +00:00
CGObjCMac.cpp CodeGen: use `llvm.used` for ObjC protocols 2018-01-23 19:35:51 +00:00
CGObjCRuntime.cpp [CodeGen] Propagate may-alias'ness of lvalues with TBAA info 2017-10-31 11:05:34 +00:00
CGObjCRuntime.h Clean up CGObjCMac's APIs for deriving class references. NFC. 2016-11-30 23:54:50 +00:00
CGOpenCLRuntime.cpp [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace 2017-12-06 10:11:28 +00:00
CGOpenCLRuntime.h [OpenCL] Emit enqueued block as kernel 2017-10-14 12:23:50 +00:00
CGOpenMPRuntime.cpp [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CGOpenMPRuntime.h [OPENMP] Add codegen for `depend` clauses on `target` directive. 2018-01-15 19:06:12 +00:00
CGOpenMPRuntimeNVPTX.cpp [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CGOpenMPRuntimeNVPTX.h [OPENMP] Add debug info for generated functions. 2018-01-04 19:45:16 +00:00
CGRecordLayout.h
CGRecordLayoutBuilder.cpp [CodeGen] Fix an assertion failure in CGRecordLowering. 2018-02-01 03:04:15 +00:00
CGStmt.cpp [CodeGen] Decorate aggregate accesses with TBAA tags 2018-01-25 14:21:55 +00:00
CGStmtOpenMP.cpp [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CGVTT.cpp Reland "Fix vtable not receiving hidden visibility when using push(visibility)" 2017-11-29 00:54:20 +00:00
CGVTables.cpp Reland "Fix vtable not receiving hidden visibility when using push(visibility)" 2017-11-29 00:54:20 +00:00
CGVTables.h CodeGen: New vtable group representation: struct of vtable arrays. 2016-12-13 20:40:39 +00:00
CGValue.h [CodeGen] Propagate may-alias'ness of lvalues with TBAA info 2017-10-31 11:05:34 +00:00
CMakeLists.txt Promote ConstantInitBuilder to be a public CodeGen API; it's 2017-03-02 20:04:19 +00:00
CodeGenABITypes.cpp Include getting generated struct offsets in CodegenABITypes 2017-10-10 23:54:21 +00:00
CodeGenAction.cpp Handle/assert on DK_Remark 2017-10-12 23:56:54 +00:00
CodeGenFunction.cpp [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CodeGenFunction.h [DebugInfo] Enable debug information for C99 VLA types 2018-02-01 11:25:10 +00:00
CodeGenModule.cpp PR36181: Teach CodeGen to properly ignore requests to emit dependent entities. 2018-02-01 00:28:36 +00:00
CodeGenModule.h [CodeGen] Decorate aggregate accesses with TBAA tags 2018-01-25 14:21:55 +00:00
CodeGenPGO.cpp Mark all library options as hidden. 2017-12-01 00:53:10 +00:00
CodeGenPGO.h Remove a dead field. NFC. 2017-04-24 20:54:36 +00:00
CodeGenTBAA.cpp [CodeGen] Decorate aggregate accesses with TBAA tags 2018-01-25 14:21:55 +00:00
CodeGenTBAA.h [CodeGen] Decorate aggregate accesses with TBAA tags 2018-01-25 14:21:55 +00:00
CodeGenTypeCache.h [AARch64] Add ARMv8.2-A FP16 vector intrinsics 2017-12-21 19:20:01 +00:00
CodeGenTypes.cpp [CodeGen][X86] Fix handling of __fp16 vectors. 2017-12-09 00:02:37 +00:00
CodeGenTypes.h [OpenCL] Emit enqueued block as kernel 2017-10-14 12:23:50 +00:00
ConstantEmitter.h Convert clang::LangAS to a strongly typed enum 2017-10-15 18:48:14 +00:00
ConstantInitBuilder.cpp Further fixes and improvements to the ConstantInitBuilder API. 2017-03-06 19:04:16 +00:00
CoverageMappingGen.cpp [Parse] Forward brace locations to TypeConstructExpr 2018-01-17 18:53:51 +00:00
CoverageMappingGen.h [Lexer] Report more precise skipped regions (PR34166) 2017-09-11 20:47:42 +00:00
EHScopeStack.h Spelling mistakes in comments. NFCI. (PR27635) 2017-03-30 14:13:19 +00:00
ItaniumCXXABI.cpp [CodeGen] Decorate aggregate accesses with TBAA tags 2018-01-25 14:21:55 +00:00
MacroPPCallbacks.cpp [NFC] Refactor the Preprocessor function that handles Macro definitions and rename Arguments to Parameters in Macro Definitions. 2017-07-17 17:18:43 +00:00
MacroPPCallbacks.h Fix API breaks 2017-04-26 20:58:21 +00:00
MicrosoftCXXABI.cpp IRGen: When performing CFI checks, load vtable pointer from vbase when necessary. 2017-12-13 21:53:04 +00:00
ModuleBuilder.cpp D34444: Teach codegen to work in incremental processing mode. 2017-08-27 10:58:03 +00:00
ObjectFilePCHContainerOperations.cpp -gmodules: Emit debug info for implicit module imports via #include. 2018-01-03 19:10:21 +00:00
README.txt
SanitizerMetadata.cpp Hardware-assisted AddressSanitizer (clang part). 2017-12-09 01:32:07 +00:00
SanitizerMetadata.h
SwiftCallingConv.cpp Simplify the internal API for checking whether swiftcall passes a type indirectly and expose that API externally. 2018-01-07 06:28:49 +00:00
TargetInfo.cpp [ARM] Pass _Float16 as int or float 2018-01-23 10:13:49 +00:00
TargetInfo.h Convert clang::LangAS to a strongly typed enum 2017-10-15 18:48:14 +00:00
VarBypassDetector.cpp [CodeGen] Don't emit lifetime intrinsics for some local variables 2016-10-26 05:42:30 +00:00
VarBypassDetector.h [CodeGen] Don't emit lifetime intrinsics for some local variables 2016-10-26 05:42:30 +00:00

README.txt

IRgen optimization opportunities.

//===---------------------------------------------------------------------===//

The common pattern of
--
short x; // or char, etc
(x == 10)
--
generates an zext/sext of x which can easily be avoided.

//===---------------------------------------------------------------------===//

Bitfields accesses can be shifted to simplify masking and sign
extension. For example, if the bitfield width is 8 and it is
appropriately aligned then is is a lot shorter to just load the char
directly.

//===---------------------------------------------------------------------===//

It may be worth avoiding creation of alloca's for formal arguments
for the common situation where the argument is never written to or has
its address taken. The idea would be to begin generating code by using
the argument directly and if its address is taken or it is stored to
then generate the alloca and patch up the existing code.

In theory, the same optimization could be a win for block local
variables as long as the declaration dominates all statements in the
block.

NOTE: The main case we care about this for is for -O0 -g compile time
performance, and in that scenario we will need to emit the alloca
anyway currently to emit proper debug info. So this is blocked by
being able to emit debug information which refers to an LLVM
temporary, not an alloca.

//===---------------------------------------------------------------------===//

We should try and avoid generating basic blocks which only contain
jumps. At -O0, this penalizes us all the way from IRgen (malloc &
instruction overhead), all the way down through code generation and
assembly time.

On 176.gcc:expr.ll, it looks like over 12% of basic blocks are just
direct branches!

//===---------------------------------------------------------------------===//