llvm-project/lldb/source/Plugins
Pavel Labath f1208e7aef ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion
Summary:
These two functions were calling each other, while handling different
branches of the if(IsInMemory()). This had a reason at some point in the
past, but right now it's just confusing.

I resolve this by removing the MemoryMapSectionData function and
inlining the !IsInMemory branch into ReadSectionData. There isn't
anything mmap-related in this function anyway, as the decision whether
to mmap is handled at a higher level.

This is a preparatory step to make ObjectFileELF be able to decompress
compressed sections (I want to make sure that all calls reading section
data are routed through a single piece of code).

Reviewers: clayborg

Subscribers: emaste, JDevlieghere, lldb-commits

Differential Revision: https://reviews.llvm.org/D41169

llvm-svn: 320705
2017-12-14 14:56:45 +00:00
..
ABI [ABI] Remove dead code that was copy-pasted all around. NFCI. 2017-11-18 00:54:31 +00:00
Architecture Move ArchSpec to the Utility module 2017-11-13 16:16:33 +00:00
Disassembler Rename Error -> Status. 2017-05-12 04:51:55 +00:00
DynamicLoader Use a static_cast instead of a C cast, NFC 2017-12-06 19:21:09 +00:00
ExpressionParser [Expression parser] Remove logging of field that is no longer in clang's TargetOptions struct. 2017-11-20 17:24:47 +00:00
Instruction Move ArchSpec to the Utility module 2017-11-13 16:16:33 +00:00
InstrumentationRuntime Upstreaming a patch from Github: When evaluation user expressions, ignore InstrumentationRuntime breakpoints. (#235) 2017-07-13 04:35:27 +00:00
JITLoader Rename Error -> Status. 2017-05-12 04:51:55 +00:00
Language Disable warnings related to anonymous types in the ObjC plugin 2017-12-07 18:57:09 +00:00
LanguageRuntime Fix some warnings found by ToT clang 2017-11-02 21:35:26 +00:00
MemoryHistory Rename Error -> Status. 2017-05-12 04:51:55 +00:00
ObjectContainer Move ArchSpec to the Utility module 2017-11-13 16:16:33 +00:00
ObjectFile Add a symbols subcommand to lldb-test. 2017-12-02 00:15:29 +00:00
OperatingSystem Move ArchSpec to the Utility module 2017-11-13 16:16:33 +00:00
Platform Fix osx build broken in r320346 2017-12-11 11:12:22 +00:00
Process Remove stderr message from GDBRemoteCommunicationServerLLGS 2017-12-14 14:56:29 +00:00
ScriptInterpreter Revert r317182 for https://reviews.llvm.org/D39128 2017-11-02 03:17:07 +00:00
StructuredData [DarwinLog] Remove other dead code. Found while reading this file. 2017-12-10 23:49:23 +00:00
SymbolFile ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion 2017-12-14 14:56:45 +00:00
SymbolVendor Add support for the DWP debug info format 2017-08-25 13:56:14 +00:00
SystemRuntime Move StructuredData from Core to Utility 2017-06-27 10:45:31 +00:00
UnwindAssembly Move ArchSpec to the Utility module 2017-11-13 16:16:33 +00:00
CMakeLists.txt Move StopInfoOverride callback to the new architecture plugin 2017-10-25 21:05:31 +00:00