maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/llvm/test/Bitcode
History
Rafael Espindola d0b23bef6f Use the DiagnosticHandler to print diagnostics when reading bitcode. 
The bitcode reading interface used std::error_code to report an error to the
callers and it is the callers job to print diagnostics.

This is not ideal for error handling or diagnostic reporting:

* For error handling, all that the callers care about is 3 possibilities:
  * It worked
  * The bitcode file is corrupted/invalid.
  * The file is not bitcode at all.

* For diagnostic, it is user friendly to include far more information
  about the invalid case so the user can find out what is wrong with the
  bitcode file. This comes up, for example, when a developer introduces a
  bug while extending the format.

The compromise we had was to have a lot of error codes.

With this patch we use the DiagnosticHandler to communicate with the
human and std::error_code to communicate with the caller.

This allows us to have far fewer error codes and adds the infrastructure to
print better diagnostics. This is so because the diagnostics are printed when
he issue is found. The code that detected the problem in alive in the stack and
can pass down as much context as needed. As an example the patch updates
test/Bitcode/invalid.ll.

Using a DiagnosticHandler also moves the fatal/non-fatal error decision to the
caller. A simple one like llvm-dis can just use fatal errors. The gold plugin
needs a bit more complex treatment because of being passed non-bitcode files. An
hypothetical interactive tool would make all bitcode errors non-fatal.

llvm-svn: 225562
 		2015-01-10 00:07:30 +00:00
..
2006-12-11-Cast-ConstExpr.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
2009-06-11-FirstClassAggregateConstant.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
aggregateInstructions.3.2.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
aggregateInstructions.3.2.ll.bc Ensure bitcode encoding of instructions and their operands stays stable. 2014-02-26 12:06:36 +00:00
arm32_neon_vcnt_upgrade.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
atomic.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
attributes-3.3.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
attributes-3.3.ll.bc
…
attributes.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
binaryFloatInstructions.3.2.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
binaryFloatInstructions.3.2.ll.bc Ensure bitcode encoding of instructions and their operands stays stable. 2014-02-26 12:06:36 +00:00
binaryIntInstructions.3.2.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
binaryIntInstructions.3.2.ll.bc Ensure bitcode encoding of instructions and their operands stays stable. 2014-02-26 12:06:36 +00:00
bitwiseInstructions.3.2.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
bitwiseInstructions.3.2.ll.bc Ensure bitcode encoding of instructions and their operands stays stable. 2014-02-26 12:06:36 +00:00
blockaddress.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
calling-conventions.3.2.ll Parse 'ghccc' in .ll files as the GHC convention (cc 10) 2014-12-01 21:04:44 +00:00
calling-conventions.3.2.ll.bc Ensure bitcode encoding of calling conventions stays stable. Patch by Boaz Ouriel. 2013-12-22 07:51:53 +00:00
case-ranges-3.3.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
case-ranges-3.3.ll.bc Revert patches to add case-range support for PR1255. 2013-09-09 19:14:35 +00:00
cmpxchg-upgrade.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
cmpxchg-upgrade.ll.bc IR: add a second ordering operand to cmpxhg for failure 2014-03-11 10:48:52 +00:00
constantsTest.3.2.ll Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
constantsTest.3.2.ll.bc Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
conversionInstructions.3.2.ll Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
conversionInstructions.3.2.ll.bc Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
drop-debug-info.ll IR: Make metadata typeless in assembly 2014-12-15 19:07:53 +00:00
extractelement.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
flags.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
function-encoding-rel-operands.ll Teach llvm-bcanalyzer to use one stream's BLOCKINFO to read another stream. 2014-08-30 17:07:55 +00:00
function-local-metadata.3.5.ll IR: Make metadata typeless in assembly 2014-12-15 19:07:53 +00:00
function-local-metadata.3.5.ll.bc IR: Fix bitcode compatability filenames 2014-12-08 00:41:39 +00:00
global-variables.3.2.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
global-variables.3.2.ll.bc Ensure bitcode encoding of global variable attributes stays stable. Patch by Boaz Ouriel. 2013-12-15 11:50:45 +00:00
highLevelStructure.3.2.ll IR: Make metadata typeless in assembly 2014-12-15 19:07:53 +00:00
highLevelStructure.3.2.ll.bc Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
inalloca.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
invalid.ll Use the DiagnosticHandler to print diagnostics when reading bitcode. 2015-01-10 00:07:30 +00:00
invalid.ll.bc Use a larger invalid attribute bitcode number 2013-10-31 19:12:36 +00:00
linkage-types-3.2.ll Make this test a bit stricter. 2015-01-08 16:11:18 +00:00
linkage-types-3.2.ll.bc Ensure bitcode encoding of linkage types stays stable. Patch by Boaz Ouriel 2013-12-01 10:16:35 +00:00
local-linkage-default-visibility.3.4.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
local-linkage-default-visibility.3.4.ll.bc IR: Don't allow non-default visibility on local linkage 2014-05-07 22:57:20 +00:00
mdstring-high-bits.ll IR: Make metadata typeless in assembly 2014-12-15 19:07:53 +00:00
memInstructions.3.2.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
memInstructions.3.2.ll.bc Ensure bitcode encoding of instructions and their operands stays stable. 2014-03-02 15:26:36 +00:00
metadata-2.ll IR: Make metadata typeless in assembly 2014-12-15 19:07:53 +00:00
metadata.3.5.ll IR: Make metadata typeless in assembly 2014-12-15 19:07:53 +00:00
metadata.3.5.ll.bc Bitcode: Add METADATA_NODE and METADATA_VALUE 2014-12-11 23:02:24 +00:00
metadata.ll IR: Make metadata typeless in assembly 2014-12-15 19:07:53 +00:00
miscInstructions.3.2.ll Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
miscInstructions.3.2.ll.bc Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
null-type.ll Change BitcodeReader to use error_code instead of bool + string. 2013-11-04 16:16:24 +00:00
null-type.ll.bc
…
old-aliases.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
old-aliases.ll.bc Fix most of PR10367. 2014-05-16 19:35:39 +00:00
pr18704.ll All new elements except the last one initialized to NULL. Ideally, once parsing is complete, all elements should be non-NULL. 2014-03-27 12:08:23 +00:00
pr18704.ll.bc All new elements except the last one initialized to NULL. Ideally, once parsing is complete, all elements should be non-NULL. 2014-03-27 12:08:23 +00:00
ptest-new.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
ptest-old.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
select.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
shuffle.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
ssse3_palignr.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
standardCIntrinsic.3.2.ll Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
standardCIntrinsic.3.2.ll.bc Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
tailcall.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
terminatorInstructions.3.2.ll Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
terminatorInstructions.3.2.ll.bc Ensure bitcode encoding stays stable. 2014-09-23 08:48:01 +00:00
upgrade-global-ctors.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
upgrade-global-ctors.ll.bc Handle ConstantAggregateZero when upgrading global_ctors. 2014-05-17 21:00:22 +00:00
upgrade-loop-metadata.ll IR: Make metadata typeless in assembly 2014-12-15 19:07:53 +00:00
upgrade-loop-metadata.ll.bc Add some test files for r211710. 2014-06-25 15:41:39 +00:00
upgrade-tbaa.ll IR: Make metadata typeless in assembly 2014-12-15 19:07:53 +00:00
use-list-order.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
variableArgumentIntrinsic.3.2.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
variableArgumentIntrinsic.3.2.ll.bc Ensure bitcode encoding of instructions and their operands stays stable. 2014-03-02 15:26:36 +00:00
vectorInstructions.3.2.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
vectorInstructions.3.2.ll.bc Ensure bitcode encoding of instructions and their operands stays stable. 2014-02-26 12:06:36 +00:00
visibility-styles.3.2.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
visibility-styles.3.2.ll.bc Ensure bitcode encoding of visibility styles stays stable. Patch by Boaz Ouriel. 2013-12-08 11:35:09 +00:00
weak-cmpxchg-upgrade.ll verify-uselistorder: Force -preserve-bc-use-list-order 2014-08-19 21:08:27 +00:00
weak-cmpxchg-upgrade.ll.bc IR: add "cmpxchg weak" variant to support permitted failure. 2014-06-13 14:24:07 +00:00