llvm-project/lld
Tobias Hieta 98bc304e9f [lld][COFF] Fix TypeServerSource lookup on GUID collisions
Microsoft shipped a bunch of PDB files with broken/invalid GUIDs
which lead lld to use 0xFF as the key for these files in an internal
cache. When multiple files have this key it will lead to collisions
and confused symbol lookup.

Several approaches to fix this was considered. Including making the key
the path to the PDB file, but this requires some filesystem operations
in order to normalize the file path.

Since this only happens with malformatted PDB files and we haven't
seen this before they malformatted files where shipped with visual
studio we probably shouldn't optimize for this use-case.

Instead we now just don't insert files with Guid == 0xFF into the
cache map and warn if we get collisions so similar problems can be
found in the future instead of being silent.

Discussion about the root issue and the approach to this fix can be found on Github: https://github.com/llvm/llvm-project/issues/54487

Reviewed By: aganea

Differential Revision: https://reviews.llvm.org/D122372
2022-04-02 10:09:07 +02:00
..
COFF [lld][COFF] Fix TypeServerSource lookup on GUID collisions 2022-04-02 10:09:07 +02:00
Common Cleanup codegen includes 2022-03-16 08:43:00 +01:00
ELF [ELF] Default to --no-fortran-common 2022-03-30 09:12:09 -07:00
MachO [lld/mac] Tweak a few comments 2022-04-01 19:32:07 -04:00
MinGW [LLD][MinGW] Add --heap argument support 2022-01-30 00:01:45 +02:00
cmake/modules [CMake] Factor out config prefix finding logic 2022-01-07 20:16:18 +00:00
docs [ELF] Default to --no-fortran-common 2022-03-30 09:12:09 -07:00
include/lld [lld] Make error handling functions opaque 2022-02-17 11:54:57 -08:00
test [lld][COFF] Fix TypeServerSource lookup on GUID collisions 2022-04-02 10:09:07 +02:00
tools/lld [LLD] Fix issue in HIP due to unspecified order of evaluation of the function object 2022-02-08 19:12:15 -05:00
utils
wasm [lld][WebAssembly] Fix crash accessing non-live __tls_base symbol 2022-03-17 13:59:45 -07:00
.clang-format
.clang-tidy NFC: .clang-tidy: Inherit configs from parents to improve maintainability 2021-06-08 08:25:59 -07:00
.gitignore
CMakeLists.txt [lld] Require C++14 in LLD standalone build 2022-02-22 18:15:29 -05:00
CODE_OWNERS.TXT
LICENSE.TXT
README.md [doc] Place sha256 in lld/README.md into backticks 2021-01-12 10:19:40 -08:00

README.md

LLVM Linker (lld)

This directory and its subdirectories contain source code for the LLVM Linker, a modular cross platform linker which is built as part of the LLVM compiler infrastructure project.

lld is open source software. You may freely distribute it under the terms of the license agreement found in LICENSE.txt.

Benchmarking

In order to make sure various developers can evaluate patches over the same tests, we create a collection of self contained programs.

It is hosted at https://s3-us-west-2.amazonaws.com/linker-tests/lld-speed-test.tar.xz

The current sha256 is 10eec685463d5a8bbf08d77f4ca96282161d396c65bd97dc99dbde644a31610f.