forked from OSchip/llvm-project
a4962cce49
Summary: The Language Server Protocol unfortunately mandates that locations in files be represented by line/column pairs, where the "column" is actually an index into the UTF-16-encoded text of the line. (This is because VSCode is written in JavaScript, which is UTF-16-native). Internally clangd treats source files at UTF-8, the One True Encoding, and generally deals with byte offsets (though there are exceptions). Before this patch, conversions between offsets and LSP Position pretended that Position.character was UTF-8 bytes, which is only true for ASCII lines. Now we examine the text to convert correctly (but don't actually need to transcode it, due to some nice details of the encodings). The updated functions in SourceCode are the blessed way to interact with the Position.character field, and anything else is likely to be wrong. So I also updated the other accesses: - CodeComplete needs a "clang-style" line/column, with column in utf-8 bytes. This is now converted via Position -> offset -> clang line/column (a new function is added to SourceCode.h for the second conversion). - getBeginningOfIdentifier skipped backwards in UTF-16 space, which is will behave badly when it splits a surrogate pair. Skipping backwards in UTF-8 coordinates gives the lexer a fighting chance of getting this right. While here, I clarified(?) the logic comments, fixed a bug with identifiers containing digits, simplified the signature slightly and added a test. This seems likely to cause problems with editors that have the same bug, and treat the protocol as if columns are UTF-8 bytes. But we can find and fix those. Reviewers: hokein Subscribers: klimek, ilya-biryukov, ioeric, MaskRay, jkorous, cfe-commits Differential Revision: https://reviews.llvm.org/D46035 llvm-svn: 331029 |
||
|---|---|---|
| .. | ||
| Inputs | ||
| completion-snippets.test | ||
| completion.test | ||
| crash-non-added-files.test | ||
| delimited-input-comment-at-the-end.test | ||
| diagnostics.test | ||
| execute-command.test | ||
| extra-flags.test | ||
| fixits.test | ||
| formatting.test | ||
| hover.test | ||
| initialize-params-invalid.test | ||
| initialize-params.test | ||
| input-mirror.test | ||
| insert-include.test | ||
| lit.local.cfg | ||
| protocol.test | ||
| rename.test | ||
| shutdown-with-exit.test | ||
| shutdown-without-exit.test | ||
| signature-help.test | ||
| spaces-in-delimited-input.test | ||
| symbols.test | ||
| test-uri-posix.test | ||
| test-uri-windows.test | ||
| textdocument-didchange-fail.test | ||
| too_large.test | ||
| trace.test | ||
| unsupported-method.test | ||
| xrefs.test | ||