maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lldb
History
David Spickett 71cf97e95b Reland "[lldb] Don't send invalid region addresses to lldb server" 
This reverts commit c65627a1fe.

The test immediately after the new invalid symbol test was
failing on Windows. This was because when we called
VirtualQueryEx to get the region info for 0x0,
even if it succeeded we would call GetLastError.

Which must have picked up the last error that was set while
trying to lookup "not_an_address". Which happened to be 2.
("The system cannot find the file specified.")

To fix this only call GetLastError when we know VirtualQueryEx
has failed. (when it returns 0, which we were also checking for anyway)

Also convert memory region to an early return style
to make the logic clearer.

Reviewed By: labath, stella.stamenova

Differential Revision: https://reviews.llvm.org/D88229
 		2020-10-05 11:50:29 +01:00
..
bindings Fix use of wrong printf format specifier for size_t argument. 2020-09-29 16:02:08 -07:00
cmake [lldb] Remove redundant call to FindBacktrace (NFC) 2020-08-20 22:41:49 -07:00
docs [lldb] Add a "design" section to the documentation. 2020-10-02 13:07:31 -07:00
examples [lldb/examples] Add missing declaration in heap.py 2020-09-24 08:44:45 -07:00
include/lldb Fix crash in SBStructuredData::GetDescription() when there's no StructuredDataPlugin. 2020-09-30 11:48:54 -07:00
packages/Python [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints. 2020-09-30 11:32:06 -07:00
resources
…
scripts Harmonize Python shebang 2020-07-16 21:53:45 +02:00
source Reland "[lldb] Don't send invalid region addresses to lldb server" 2020-10-05 11:50:29 +01:00
test Reland "[lldb] Don't send invalid region addresses to lldb server" 2020-10-05 11:50:29 +01:00
third_party/Python/module Revert "[lldb] temporary commit to see why a test is failing only on lldb-aarch64-ubuntu" 2020-08-05 11:55:02 +02:00
tools [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints. 2020-09-30 11:32:06 -07:00
unittests [lldb/ipv6] Support running lldb tests in an ipv6-only environment. 2020-09-30 11:08:41 -07:00
utils [lldb] Hoist -s (trace directory) argument out of LLDB_TEST_COMMON_ARGS (NFC) 2020-09-29 17:23:33 -07:00
.clang-format
…
.clang-tidy [lldb] Add .clang-tidy with customization to disable readability-identifier-naming 2020-03-09 12:50:28 -07:00
.gitignore
…
CMakeLists.txt Create ${swig_target}-scripts target instead of lldb-python-scripts 2020-08-22 19:36:37 -07:00
CODE_OWNERS.txt [lldb][NFC] Cleanup mentions and code related to lldb-mi 2019-07-19 15:55:23 +00:00
LICENSE.TXT
…
use_lldb_suite_root.py
…