forked from OSchip/llvm-project
8fd74ebfc0
Unfortunately, up until now, the fact that certain checkers depended on one another was known, but how these actually unfolded was hidden deep within the implementation. For example, many checkers (like RetainCount, Malloc or CString) modelled a certain functionality, and exposed certain reportable bug types to the user. For example, while MallocChecker models many many different types of memory handling, the actual "unix.MallocChecker" checker the user was exposed to was merely and option to this modeling part. Other than this being an ugly mess, this issue made resolving the checker naming issue almost impossible. (The checker naming issue being that if a checker registered more than one checker within its registry function, both checker object recieved the same name) Also, if the user explicitly disabled a checker that was a dependency of another that _was_ explicitly enabled, it implicitly, without "telling" the user, reenabled it. Clearly, changing this to a well structured, declarative form, where the handling of dependencies are done on a higher level is very much preferred. This patch, among the detailed things later, makes checkers declare their dependencies within the TableGen file Checkers.td, and exposes the same functionality to plugins and statically linked non-generated checkers through CheckerRegistry::addDependency. CheckerRegistry now resolves these dependencies, makes sure that checkers are added to CheckerManager in the correct order, and makes sure that if a dependency is disabled, so will be every checker that depends on it. In detail: * Add a new field to the Checker class in CheckerBase.td called Dependencies, which is a list of Checkers. * Move unix checkers before cplusplus, as there is no forward declaration in tblgen :/ * Add the following new checkers: - StackAddrEscapeBase - StackAddrEscapeBase - CStringModeling - DynamicMemoryModeling (base of the MallocChecker family) - IteratorModeling (base of the IteratorChecker family) - ValistBase - SecuritySyntaxChecker (base of bcmp, bcopy, etc...) - NSOrCFErrorDerefChecker (base of NSErrorChecker and CFErrorChecker) - IvarInvalidationModeling (base of IvarInvalidation checker family) - RetainCountBase (base of RetainCount and OSObjectRetainCount) * Clear up and registry functions in MallocChecker, happily remove old FIXMEs. * Add a new addDependency function to CheckerRegistry. * Neatly format RUN lines in files I looked at while debugging. Big thanks to Artem Degrachev for all the guidance through this project! Differential Revision: https://reviews.llvm.org/D54438 llvm-svn: 352287 |
||
|---|---|---|
| .. | ||
| Inputs/expected-plists | ||
| DynDispatchBifurcate.m | ||
| InlineObjCClassMethod.m | ||
| InlineObjCInstanceMethod.h | ||
| InlineObjCInstanceMethod.m | ||
| ObjCDynTypePopagation.m | ||
| ObjCImproperDynamictallyDetectableCast.m | ||
| RetainCountExamples.m | ||
| analysis-order.c | ||
| assume-super-init-does-not-return-nil.m | ||
| containers.cpp | ||
| dyn-dispatch-bifurcate.cpp | ||
| eager-reclamation-path-notes.c | ||
| eager-reclamation-path-notes.cpp | ||
| false-positive-suppression.c | ||
| false-positive-suppression.cpp | ||
| false-positive-suppression.m | ||
| inline-defensive-checks.c | ||
| inline-defensive-checks.cpp | ||
| inline-defensive-checks.m | ||
| path-notes.c | ||
| path-notes.cpp | ||
| path-notes.m | ||
| retain-count-self-init.m | ||
| stl.cpp | ||
| temp-dtors-path-notes.cpp | ||
| test-always-inline-size-option.c | ||
| test_objc_inlining_option.m | ||