forked from OSchip/llvm-project
72ba78c29e
This looks like just an oversight in the AsyncThread function. It gets a result of eStateInvalid, and then marks the process as exited, but doesn't set "done" to true, so we go to fetch another event. That is not safe, since you don't know when that extra packet is going to arrive. If it arrives while you are tearing down the process, the internal-state-thread might try to handle it when the process in not in a good state. Rather than put more effort into checking all the shutdown paths to make sure this extra packet doesn't cause problems, just don't fetch it. We weren't going to do anything useful with it anyway. The main part of the patch is setting "done = true" when we get the eStateInvalid. I also added a check at the beginning of the while(done) loop to prevent another error from getting us to fetch packets for an exited process. I added a test case to ensure that if an Interrupt fails, we call the process exited. I can't test exactly the error I'm fixing, there's no good way to know that the stop reply for the failed interrupt wasn't fetched. But at least this asserts that the overall behavior is correct. Differential Revision: https://reviews.llvm.org/D101933 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| GDBRemoteClientBase.cpp | ||
| GDBRemoteClientBase.h | ||
| GDBRemoteCommunication.cpp | ||
| GDBRemoteCommunication.h | ||
| GDBRemoteCommunicationClient.cpp | ||
| GDBRemoteCommunicationClient.h | ||
| GDBRemoteCommunicationHistory.cpp | ||
| GDBRemoteCommunicationHistory.h | ||
| GDBRemoteCommunicationReplayServer.cpp | ||
| GDBRemoteCommunicationReplayServer.h | ||
| GDBRemoteCommunicationServer.cpp | ||
| GDBRemoteCommunicationServer.h | ||
| GDBRemoteCommunicationServerCommon.cpp | ||
| GDBRemoteCommunicationServerCommon.h | ||
| GDBRemoteCommunicationServerLLGS.cpp | ||
| GDBRemoteCommunicationServerLLGS.h | ||
| GDBRemoteCommunicationServerPlatform.cpp | ||
| GDBRemoteCommunicationServerPlatform.h | ||
| GDBRemoteRegisterContext.cpp | ||
| GDBRemoteRegisterContext.h | ||
| ProcessGDBRemote.cpp | ||
| ProcessGDBRemote.h | ||
| ProcessGDBRemoteLog.cpp | ||
| ProcessGDBRemoteLog.h | ||
| ProcessGDBRemoteProperties.td | ||
| ThreadGDBRemote.cpp | ||
| ThreadGDBRemote.h | ||