llvm-project/lldb/source/Breakpoint
Med Ismail Bennani 35ecfda01c [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match
This patch fixes the column symbol resolution when creating a breakpoint
with the `move_to_nearest_code` flag set.

In order to achieve this, the patch adds column information handling in
the `LineTable`'s `LineEntry` finder. After experimenting a little, it
turns out the most natural approach in case of an inaccurate column match,
is to move backward and match the previous `LineEntry` rather than going
forward like we do with simple line breakpoints.

The patch also reflows the function to reduce code duplication.

Finally, it updates the `BreakpointResolver` heuristic to align it with
the `LineTable` method.

rdar://73218201

Differential Revision: https://reviews.llvm.org/D101221

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
2021-05-05 05:07:50 +00:00
..
Breakpoint.cpp [lldb] Refactor argument group by SourceLocationSpec (NFCI) 2021-05-04 23:04:31 +00:00
BreakpointID.cpp [lldb] Remove redundant WithFormat suffixes (NFC) 2020-07-20 23:00:32 -07:00
BreakpointIDList.cpp [lldb] Fix redundant newline in AppendError calls. 2020-07-20 23:11:56 -07:00
BreakpointList.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointLocation.cpp Make the stop-on-sharedlibrary-events setting work. 2021-03-24 11:15:11 -07:00
BreakpointLocationCollection.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointLocationList.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointName.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointOptions.cpp Make the stop-on-sharedlibrary-events setting work. 2021-03-24 11:15:11 -07:00
BreakpointPrecondition.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
BreakpointResolver.cpp [lldb/Symbol] Fix column breakpoint `move_to_nearest_code` match 2021-05-05 05:07:50 +00:00
BreakpointResolverAddress.cpp [lldb][NFC] Remove dead code in BreakpointResolverAddress 2020-08-10 11:29:40 +02:00
BreakpointResolverFileLine.cpp [lldb] Refactor argument group by SourceLocationSpec (NFCI) 2021-05-04 23:04:31 +00:00
BreakpointResolverFileRegex.cpp [lldb] Refactor argument group by SourceLocationSpec (NFCI) 2021-05-04 23:04:31 +00:00
BreakpointResolverName.cpp [lldb] Remove redundant WithFormat suffixes (NFC) 2020-07-20 23:00:32 -07:00
BreakpointResolverScripted.cpp [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint 2020-03-04 16:56:50 +03:00
BreakpointSite.cpp [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation 2020-07-29 22:07:46 +03:00
BreakpointSiteList.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
CMakeLists.txt [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation 2020-07-29 22:07:46 +03:00
Stoppoint.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
StoppointCallbackContext.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
StoppointSite.cpp [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation 2020-07-29 22:07:46 +03:00
Watchpoint.cpp [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation 2020-07-29 22:07:46 +03:00
WatchpointList.cpp [lldb][NFC] Fix all formatting errors in .cpp file headers 2020-01-24 08:52:55 +01:00
WatchpointOptions.cpp [lldb] Use std::make_unique<> (NFC) 2020-06-24 17:48:40 -07:00