forked from OSchip/llvm-project
![]() Summary: 1. Don't have isHidden() depend on isNeeded(). Whether a section is hidden is orthogonal from whether it is needed: hidden sections will never have a header regardless of whether they have a body. (I know we override this method with return false for synthetic sections, but regardless I think it's confusing to write it this way for non-synthetic sections.) 2. Don't call writeTo() on unneeded sections. D78270 assumes that this is true when implementing the stub helper section. 3. Filter out the unneeded sections early on to avoid having to deal with them in multiple places. 4. Remove assumption in test that the referenced file has no other symbols. (We should create separate input files for future tests to avoid such issues.) Reviewers: ruiu, pcc, MaskRay, smeenai, alexshap, gkm, Ktwu, christylee Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D79460 |
||
---|---|---|
.. | ||
Arch | ||
CMakeLists.txt | ||
Config.h | ||
Driver.cpp | ||
Driver.h | ||
ExportTrie.cpp | ||
ExportTrie.h | ||
InputFiles.cpp | ||
InputFiles.h | ||
InputSection.cpp | ||
InputSection.h | ||
MergedOutputSection.cpp | ||
MergedOutputSection.h | ||
Options.td | ||
OutputSection.cpp | ||
OutputSection.h | ||
OutputSegment.cpp | ||
OutputSegment.h | ||
SymbolTable.cpp | ||
SymbolTable.h | ||
Symbols.cpp | ||
Symbols.h | ||
SyntheticSections.cpp | ||
SyntheticSections.h | ||
Target.cpp | ||
Target.h | ||
Writer.cpp | ||
Writer.h |