llvm-project/llvm/lib/Target/WebAssembly
Sam Clegg 1b6d879ec1 [WebAssembly] Fix code generated for atomic operations in PIC mode
The main this this test does is to add the `IsNotPIC` predicate to the
all the atomic instructions pattern that directly refer to
`tglobaladdr`.

This is because in PIC mode we need to generate separate instruction
sequence (either a direct global.get, or __memory_base + offset) for
accessing global addresses.

As part of this change I noticed that many of the `Requires` attributes
added to the instruction in `WebAssemblyInstrAtomics.td` were being
honored.  This is because the wrapped in a `let Predicates =
[HasAtomics]` block and it seems that that outer wrapping overrides any
`Requires` on defs within it.   As a workaround I removed the outer
`let` and added `HasAtomics` to all the inner `Requires`.  I believe
that all the instrucitons that don't have `Requires` explicit bottom out
in `ATOMIC_I` and `ATOMIC_NRI` which have `HasAtomics` so this should
not remove this predicate from any patterns (at least that is the idea).

The alternative to this approach looks like implementing something
like `PredicateControl` in `Mips.td` where we can split the predicates
into groups so they don't clobber each other.

Differential Revision: https://reviews.llvm.org/D92744
2020-12-08 18:41:32 -08:00
..
AsmParser [WebAssembly] Support select and block for reference types 2020-12-01 19:16:57 -08:00
Disassembler llvmbuildectomy - replace llvm-build by plain cmake 2020-11-13 10:35:24 +01:00
MCTargetDesc [WebAssembly] Support select and block for reference types 2020-12-01 19:16:57 -08:00
TargetInfo llvmbuildectomy - replace llvm-build by plain cmake 2020-11-13 10:35:24 +01:00
CMakeLists.txt llvmbuildectomy - replace llvm-build by plain cmake 2020-11-13 10:35:24 +01:00
README.txt
WebAssembly.h
WebAssembly.td
WebAssemblyAddMissingPrototypes.cpp
WebAssemblyArgumentMove.cpp
WebAssemblyAsmPrinter.cpp [WebAssembly] Added .tabletype to asm and multiple table support in obj files 2020-10-13 07:52:23 -07:00
WebAssemblyAsmPrinter.h [WebAssembly] Rename Emscripten EH functions 2020-10-07 09:42:49 -07:00
WebAssemblyCFGSort.cpp [WebAssembly] Fix getBottom for loops 2020-07-29 10:36:32 -07:00
WebAssemblyCFGStackify.cpp [WebAssembly] Support select and block for reference types 2020-12-01 19:16:57 -08:00
WebAssemblyDebugFixup.cpp
WebAssemblyDebugValueManager.cpp [DebugInfo] Update MachineInstr to help support variadic DBG_VALUE instructions 2020-06-22 16:01:12 +01:00
WebAssemblyDebugValueManager.h
WebAssemblyExceptionInfo.cpp
WebAssemblyExceptionInfo.h
WebAssemblyExplicitLocals.cpp [WebAssembly] Support select and block for reference types 2020-12-01 19:16:57 -08:00
WebAssemblyFastISel.cpp [WebAssembly] Support select and block for reference types 2020-12-01 19:16:57 -08:00
WebAssemblyFixBrTableDefaults.cpp [WebAssembly] Fixed 64-bit indices in br_table 2020-07-30 10:52:16 -07:00
WebAssemblyFixFunctionBitcasts.cpp
WebAssemblyFixIrreducibleControlFlow.cpp
WebAssemblyFrameLowering.cpp [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals 2020-06-25 15:52:44 -07:00
WebAssemblyFrameLowering.h [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals 2020-06-25 15:52:44 -07:00
WebAssemblyISD.def [WebAssembly] Remove intrinsics for SIMD widening ops 2020-07-28 18:25:55 -07:00
WebAssemblyISelDAGToDAG.cpp [WebAssembly] Move GlobalTLSAddress handling to WebAssemblyISelLowering. NFC 2020-11-13 14:35:51 -08:00
WebAssemblyISelLowering.cpp [WebAssembly] Support fp reg class in r constraint 2020-11-18 17:05:58 -08:00
WebAssemblyISelLowering.h [WebAssembly] Add new relocation type for TLS data symbols 2020-11-13 07:59:29 -08:00
WebAssemblyInstrAtomics.td [WebAssembly] Fix code generated for atomic operations in PIC mode 2020-12-08 18:41:32 -08:00
WebAssemblyInstrBulkMemory.td [WebAssembly] wasm64: fix memory.init operand types 2020-08-10 10:15:20 -07:00
WebAssemblyInstrCall.td
WebAssemblyInstrControl.td [WebAssembly] Set unreachable as canonical to permit disassembly 2020-09-10 15:04:16 -04:00
WebAssemblyInstrConv.td
WebAssemblyInstrFloat.td
WebAssemblyInstrFormats.td [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs 2020-06-15 10:07:42 -07:00
WebAssemblyInstrInfo.cpp [WebAssembly] Support select and block for reference types 2020-12-01 19:16:57 -08:00
WebAssemblyInstrInfo.h
WebAssemblyInstrInfo.td [WebAssembly] Move GlobalTLSAddress handling to WebAssemblyISelLowering. NFC 2020-11-13 14:35:51 -08:00
WebAssemblyInstrInteger.td
WebAssemblyInstrMemory.td [WebAssembly] Implement prototype v128.load{32,64}_zero instructions 2020-08-03 13:54:00 -07:00
WebAssemblyInstrRef.td [WebAssembly] Support select and block for reference types 2020-12-01 19:16:57 -08:00
WebAssemblyInstrSIMD.td [WebAssembly] Prototype i64x2.bitmask 2020-10-30 17:23:30 -07:00
WebAssemblyInstrTable.td [WebAssembly] Implementation of (most) table instructions 2020-10-23 08:42:54 -07:00
WebAssemblyLateEHPrepare.cpp [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals 2020-06-25 15:52:44 -07:00
WebAssemblyLowerBrUnless.cpp WebAssembly: Don't store MachineFunction in MachineFunctionInfo 2020-06-24 10:52:58 -04:00
WebAssemblyLowerEmscriptenEHSjLj.cpp [WebAssembly] Handle indirect uses of longjmp 2020-10-08 11:37:19 -07:00
WebAssemblyLowerGlobalDtors.cpp
WebAssemblyMCInstLower.cpp [WebAssembly] Add new relocation type for TLS data symbols 2020-11-13 07:59:29 -08:00
WebAssemblyMCInstLower.h
WebAssemblyMachineFunctionInfo.cpp WebAssembly: Don't store MachineFunction in MachineFunctionInfo 2020-06-24 10:52:58 -04:00
WebAssemblyMachineFunctionInfo.h WebAssembly: Don't store MachineFunction in MachineFunctionInfo 2020-06-24 10:52:58 -04:00
WebAssemblyMemIntrinsicResults.cpp
WebAssemblyOptimizeLiveIntervals.cpp [NFC][Regalloc] accessors for 'reg' and 'weight' 2020-09-16 08:28:57 -07:00
WebAssemblyOptimizeReturned.cpp
WebAssemblyPeephole.cpp [WebAssembly] Support select and block for reference types 2020-12-01 19:16:57 -08:00
WebAssemblyPrepareForLiveIntervals.cpp
WebAssemblyRegColoring.cpp [NFC][Regalloc] accessors for 'reg' and 'weight' 2020-09-16 08:28:57 -07:00
WebAssemblyRegNumbering.cpp WebAssembly: Don't store MachineFunction in MachineFunctionInfo 2020-06-24 10:52:58 -04:00
WebAssemblyRegStackify.cpp [NFC][MC] MCRegister API typing. 2020-10-08 15:08:34 -07:00
WebAssemblyRegisterInfo.cpp [WebAssembly] Don't fold frame offset for global addresses 2020-11-03 14:56:25 -08:00
WebAssemblyRegisterInfo.h
WebAssemblyRegisterInfo.td [WebAssembly] Implementation of (most) table instructions 2020-10-23 08:42:54 -07:00
WebAssemblyReplacePhysRegs.cpp
WebAssemblyRuntimeLibcallSignatures.cpp
WebAssemblyRuntimeLibcallSignatures.h
WebAssemblySelectionDAGInfo.cpp [WebAssembly] Added 64-bit memory.grow/size/copy/fill 2020-07-06 12:49:50 -07:00
WebAssemblySelectionDAGInfo.h [Alignment][NFC] Migrate SelectionDAGTargetInfo::EmitTargetCodeForMemcpy to Align 2020-06-30 13:12:31 +00:00
WebAssemblySetP2AlignOperands.cpp
WebAssemblySortRegion.cpp [WebAssembly] Fix GCC 5 build. 2020-07-30 10:00:28 -07:00
WebAssemblySortRegion.h [WebAssembly] Fix getBottom for loops 2020-07-29 10:36:32 -07:00
WebAssemblySubtarget.cpp [X86][MC][Target] Initial backend support a tune CPU to support -mtune 2020-08-14 15:31:50 -07:00
WebAssemblySubtarget.h [X86][MC][Target] Initial backend support a tune CPU to support -mtune 2020-08-14 15:31:50 -07:00
WebAssemblyTargetMachine.cpp [WebAssembly] Add new relocation type for TLS data symbols 2020-11-13 07:59:29 -08:00
WebAssemblyTargetMachine.h [WebAssembly] Check features before making SjLj vars thread-local 2020-09-25 11:45:16 -07:00
WebAssemblyTargetObjectFile.cpp
WebAssemblyTargetObjectFile.h
WebAssemblyTargetTransformInfo.cpp [WebAssembly] Allow inlining functions with different features 2020-08-13 13:57:43 -07:00
WebAssemblyTargetTransformInfo.h [WebAssembly] Allow inlining functions with different features 2020-08-13 13:57:43 -07:00
WebAssemblyUtilities.cpp
WebAssemblyUtilities.h WebAssemblyUtilities.h - reduce unnecessary includes to forward declarations. NFCI. 2020-09-03 17:43:35 +01:00
known_gcc_test_failures.txt

README.txt

//===-- README.txt - Notes for WebAssembly code gen -----------------------===//

This WebAssembly backend is presently under development.

The most notable feature which is not yet stable is the ".o" file format.
".o" file support is needed for many common ways of using LLVM, such as
using it through "clang -c", so this backend is not yet considered widely
usable. However, this backend is usable within some language toolchain
packages:

Emscripten provides a C/C++ compilation environment that includes standard
libraries, tools, and packaging for producing WebAssembly applications that
can run in browsers and other environments. For more information, see the
Emscripten documentation in general, and this page in particular:

  * https://github.com/kripken/emscripten/wiki/New-WebAssembly-Backend

Rust provides WebAssembly support integrated into Cargo. There are two
main options:
 - wasm32-unknown-unknown, which provides a relatively minimal environment
   that has an emphasis on being "native"
 - wasm32-unknown-emscripten, which uses Emscripten internally and
   provides standard C/C++ libraries, filesystem emulation, GL and SDL
   bindings
For more information, see:
  * https://www.hellorust.com/


This backend does not yet support debug info. Full DWARF support needs a
design for how DWARF should be represented in WebAssembly. Sourcemap support
has an existing design and some corresponding browser implementations, so it
just needs implementing in LLVM.

Work-in-progress documentation for the ".o" file format is here:

  * https://github.com/WebAssembly/tool-conventions/blob/master/Linking.md

A corresponding linker implementation is also under development:

  * https://lld.llvm.org/WebAssembly.html

For more information on WebAssembly itself, see the home page:
  * https://webassembly.github.io/

The following documents contain some information on the semantics and binary
encoding of WebAssembly itself:
  * https://github.com/WebAssembly/design/blob/master/Semantics.md
  * https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md

The backend is built, tested and archived on the following waterfall:
  https://wasm-stat.us

The backend's bringup is done in part by using the GCC torture test suite, since
it doesn't require C library support. Current known failures are in
known_gcc_test_failures.txt, all other tests should pass. The waterfall will
turn red if not. Once most of these pass, further testing will use LLVM's own
test suite. The tests can be run locally using:
  https://github.com/WebAssembly/waterfall/blob/master/src/compile_torture_tests.py

Some notes on ways that the generated code could be improved follow:

//===---------------------------------------------------------------------===//

Br, br_if, and br_table instructions can support having a value on the value
stack across the jump (sometimes). We should (a) model this, and (b) extend
the stackifier to utilize it.

//===---------------------------------------------------------------------===//

The min/max instructions aren't exactly a<b?a:b because of NaN and negative zero
behavior. The ARM target has the same kind of min/max instructions and has
implemented optimizations for them; we should do similar optimizations for
WebAssembly.

//===---------------------------------------------------------------------===//

AArch64 runs SeparateConstOffsetFromGEPPass, followed by EarlyCSE and LICM.
Would these be useful to run for WebAssembly too? Also, it has an option to
run SimplifyCFG after running the AtomicExpand pass. Would this be useful for
us too?

//===---------------------------------------------------------------------===//

Register stackification uses the VALUE_STACK physical register to impose
ordering dependencies on instructions with stack operands. This is pessimistic;
we should consider alternate ways to model stack dependencies.

//===---------------------------------------------------------------------===//

Lots of things could be done in WebAssemblyTargetTransformInfo.cpp. Similarly,
there are numerous optimization-related hooks that can be overridden in
WebAssemblyTargetLowering.

//===---------------------------------------------------------------------===//

Instead of the OptimizeReturned pass, which should consider preserving the
"returned" attribute through to MachineInstrs and extending the
MemIntrinsicResults pass to do this optimization on calls too. That would also
let the WebAssemblyPeephole pass clean up dead defs for such calls, as it does
for stores.

//===---------------------------------------------------------------------===//

Consider implementing optimizeSelect, optimizeCompareInstr, optimizeCondBranch,
optimizeLoadInstr, and/or getMachineCombinerPatterns.

//===---------------------------------------------------------------------===//

Find a clean way to fix the problem which leads to the Shrink Wrapping pass
being run after the WebAssembly PEI pass.

//===---------------------------------------------------------------------===//

When setting multiple local variables to the same constant, we currently get
code like this:

    i32.const   $4=, 0
    i32.const   $3=, 0

It could be done with a smaller encoding like this:

    i32.const   $push5=, 0
    local.tee   $push6=, $4=, $pop5
    local.copy  $3=, $pop6

//===---------------------------------------------------------------------===//

WebAssembly registers are implicitly initialized to zero. Explicit zeroing is
therefore often redundant and could be optimized away.

//===---------------------------------------------------------------------===//

Small indices may use smaller encodings than large indices.
WebAssemblyRegColoring and/or WebAssemblyRegRenumbering should sort registers
according to their usage frequency to maximize the usage of smaller encodings.

//===---------------------------------------------------------------------===//

Many cases of irreducible control flow could be transformed more optimally
than via the transform in WebAssemblyFixIrreducibleControlFlow.cpp.

It may also be worthwhile to do transforms before register coloring,
particularly when duplicating code, to allow register coloring to be aware of
the duplication.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify could use AliasAnalysis to reorder loads and stores more
aggressively.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify is currently a greedy algorithm. This means that, for
example, a binary operator will stackify with its user before its operands.
However, if moving the binary operator to its user moves it to a place where
its operands can't be moved to, it would be better to leave it in place, or
perhaps move it up, so that it can stackify its operands. A binary operator
has two operands and one result, so in such cases there could be a net win by
preferring the operands.

//===---------------------------------------------------------------------===//

Instruction ordering has a significant influence on register stackification and
coloring. Consider experimenting with the MachineScheduler (enable via
enableMachineScheduler) and determine if it can be configured to schedule
instructions advantageously for this purpose.

//===---------------------------------------------------------------------===//

WebAssemblyRegStackify currently assumes that the stack must be empty after
an instruction with no return values, however wasm doesn't actually require
this. WebAssemblyRegStackify could be extended, or possibly rewritten, to take
full advantage of what WebAssembly permits.

//===---------------------------------------------------------------------===//

Add support for mergeable sections in the Wasm writer, such as for strings and
floating-point constants.

//===---------------------------------------------------------------------===//

The function @dynamic_alloca_redzone in test/CodeGen/WebAssembly/userstack.ll
ends up with a local.tee in its prolog which has an unused result, requiring
an extra drop:

    global.get  $push8=, 0
    local.tee   $push9=, 1, $pop8
    drop        $pop9
    [...]

The prologue code initially thinks it needs an FP register, but later it
turns out to be unneeded, so one could either approach this by being more
clever about not inserting code for an FP in the first place, or optimizing
away the copy later.

//===---------------------------------------------------------------------===//