llvm-project/lldb
Pavel Labath 9cdd68e7c1 Recommit "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)"
The patch was reverted 27d52cd86a because of failures in
TestWeakSymbols.py. These have now been addressed in D83552.

The original commit message was:
This function was documented to overwrite entries with D76111, which was
adding a couple of similar functions. However, this function (unlike the
functions added in that patch) was/is not actually overwriting variables
-- any pre-existing variables would get ignored.

This behavior does not seem to be intentional. In fact, before the refactor in
D41359, this function could introduce duplicate entries, which could
have very surprising effects both inside lldb and on other applications
(some applications would take the first value, some the second one; in
lldb, attempting to unset a variable could make the second variable
become active, etc.).

Overwriting seems to be the most reasonable behavior here, so change the
code to match documentation.

Differential Revision: https://reviews.llvm.org/D83306
2020-07-23 14:17:57 +02:00
..
bindings [lldb] Make sure we don't leak SBThreadPlan pointer (NFCI) 2020-07-20 16:58:06 -07:00
cmake [lldb/Lua] Require Lua 5.3 2020-06-23 09:24:01 -07:00
docs Updated the list of supported platforms in LLDB to include Apple silicon. 2020-07-08 15:33:00 -07:00
examples Harmonize Python shebang 2020-07-16 21:53:45 +02:00
include/lldb Temporarily Revert "Reland [lldb] Unify type name matching in FormattersContainer" 2020-07-23 00:47:05 -07:00
packages/Python [lldb] add printing of stdout compile errors to lldbsuite 2020-07-22 16:38:20 +02:00
resources
scripts Harmonize Python shebang 2020-07-16 21:53:45 +02:00
source Recommit "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)" 2020-07-23 14:17:57 +02:00
test Recommit "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)" 2020-07-23 14:17:57 +02:00
third_party/Python/module Harmonize Python shebang 2020-07-16 21:53:45 +02:00
tools [CMake] Bump CMake minimum version to 3.13.4 2020-07-22 14:25:07 -04:00
unittests Temporarily Revert "Reland [lldb] Unify type name matching in FormattersContainer" 2020-07-23 00:47:05 -07:00
utils [lldb/Test] Fix missing yaml2obj in Xcode standalone build. 2020-07-10 21:34:56 -07:00
.clang-format
.clang-tidy [lldb] Add .clang-tidy with customization to disable readability-identifier-naming 2020-03-09 12:50:28 -07:00
.gitignore
CMakeLists.txt [CMake] Bump CMake minimum version to 3.13.4 2020-07-22 14:25:07 -04:00
CODE_OWNERS.txt
LICENSE.TXT
use_lldb_suite_root.py