llvm-project/lldb
Raphael Isemann b448d1bf21 [lldb] Fix dynamic_cast by no longer failing on variable without metadata
Summary:
Our IR rewriting infrastructure currently fails when it encounters a variable which has no metadata associated.
This causes dynamic_cast to fail as in this case IRForTarget considers the type info pointers ('@_ZTI...') to be
variables without associated metadata. As there are no variables for these internal variables, this is actually
not an error and dynamic_cast would work fine if we didn't throw this error.

This patch fixes this by removing this diagnostics code. In case we would actually hit a variable that has no
metadata (but is supposed to have), we still have the error in the expression log so this shouldn't make it
harder to diagnose any missing metadata errors.

This patch should fix dynamic_cast and also adds a bunch of test coverage to that language feature.

Fixes rdar://10813639

Reviewers: davide, labath

Reviewed By: labath

Subscribers: friss, labath, abidh, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D65932

llvm-svn: 368511
2019-08-10 10:56:17 +00:00
..
cmake [lldb][CMake] Disable modules in Xcode projects 2019-08-08 13:39:25 +00:00
docs [Docs] Fix (incorrect) code highlighting 2019-08-07 23:12:40 +00:00
examples [Symbolication] Remove some dead code. Nothing exciting. 2019-07-29 21:25:51 +00:00
include/lldb Remove unused and undocumented data_offset parameter (NFC) 2019-08-08 19:22:32 +00:00
lit Minidump/Windows: Fix module lookup 2019-08-09 09:10:50 +00:00
packages/Python/lldbsuite [lldb] Fix dynamic_cast by no longer failing on variable without metadata 2019-08-10 10:56:17 +00:00
resources [CMake] Revised LLDB.framework builds 2019-01-04 12:46:50 +00:00
scripts [lldb] Remove Xcode project legacy 2019-07-24 09:20:14 +00:00
source [lldb] Fix dynamic_cast by no longer failing on variable without metadata 2019-08-10 10:56:17 +00:00
test [dotest] Remove multiprocessing 2019-07-30 16:42:47 +00:00
third_party/Python/module [lldb/thirdparty] Remove unneeded files, asked by Jonas. 2019-03-12 20:41:36 +00:00
tools [lldb][CMake] Workaround debugserver code-signing issue in generated Xcode project 2019-08-07 11:02:04 +00:00
unittests ObjectFileELF: Convert a unit test to a lit test 2019-08-08 12:57:46 +00:00
utils [TableGen] Move helpers into LLDBTableGenUtils. 2019-07-31 00:47:00 +00:00
.arcconfig
.clang-format
.gitignore Add .noindex to the gitignore 2019-04-05 17:57:42 +00:00
CMakeLists.txt [CMake] Remove check for the readline target. 2019-08-05 23:54:13 +00:00
CODE_OWNERS.txt [lldb][NFC] Cleanup mentions and code related to lldb-mi 2019-07-19 15:55:23 +00:00
LICENSE.TXT Fix typos throughout the license files that somehow I and my reviewers 2019-01-21 09:52:34 +00:00
use_lldb_suite_root.py