forked from OSchip/llvm-project
22fc007809
The philosophy of the error checking in libObject for Mach-O files is that the constructor will check the load commands so for their tables the offsets and sizes are properly contained in the file. But there is no checking of the entries of any of the tables. For the contents of the tables themselves the methods accessing the contents of the entries return errors as needed. In some cases this however makes it difficult or cumbersome to produce a good error message which would include the tool name, file name, archive member, and name of the architecture of a slice of a universal file the error occurred in. So idea is that there will be a method to check a table which can be called up front before using it allowing a good error message to be produced before a table is used. And if only verification of the Mach-O file and its tables are wanted a new possible method checkAllTables() could be added to call all of the methods to check all the tables at some time when such methods exist. The checkSymbolTable() is the first of such methods to check one of the Mach-O file tables. This method initially will used in llvm-objdump’s DisassembleMachO() routine before it gets the section and symbol information. As if there are problems with the symbol table currently the error is first encountered by the bool operator() in the SymbolSorter() struct which passed to std::sort(). In this case there is no context as to the file name the symbol which results a poor error message: LLVM ERROR: truncated or malformed object (bad string index: 22 for symbol at index 1) with the added call to the checkSymbolTable() method the error message includes the tool name and file name: llvm-objdump: 'macho-invalid-symbol-strx': truncated or malformed object (bad string table index: 22 past the end of string table, for symbol at index 1) llvm-svn: 286887 |
||
|---|---|---|
| .. | ||
| AArch64 | ||
| ARM | ||
| Hexagon | ||
| Inputs | ||
| X86 | ||
| coff-file.test | ||
| coff-import-library.test | ||
| coff-large-bss.test | ||
| coff-many-relocs.test | ||
| coff-non-null-terminated-file.test | ||
| coff-private-headers.test | ||
| common-symbol-elf.test | ||
| eh_frame-arm64.test | ||
| eh_frame-mipsel.test | ||
| eh_frame_zero_cie.test | ||
| hex-relocation-addr.test | ||
| invalid-input.test | ||
| macho-LLVM-bundle.test | ||
| macho-bad-ordinal.test | ||
| macho-bind.test | ||
| macho-bind2.test | ||
| macho-compact-unwind-i386.test | ||
| macho-compact-unwind-x86_64.test | ||
| macho-exports-trie.test | ||
| macho-lazy-bind.test | ||
| macho-objc-meta-data.test | ||
| macho-rebase.test | ||
| macho-sections.test | ||
| macho-unwind-info-arm64.test | ||
| macho-unwind-info-no-relocs.test | ||
| macho-unwind-info-x86_64.test | ||
| macho-weak-bind.test | ||
| malformed-archives.test | ||
| malformed-macho.test | ||
| proc-specific-section-elf.test | ||
| section-filter.test | ||
| win64-unwind-data.test | ||