llvm-project/lldb
Pavel Labath d8aca8886f Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups
Summary:
The motivation for this was me wanting to make the validity of dwarf
DIERefs explicit (via llvm::Optional<DIERef>). This meant that the class
would no longer have a default constructor. As the DIERef was being
stored in a UniqueCStringMap, this meant that this container (like all
standard containers) needed to work with non-default-constructible types
too.

This part is achieved by removing the default constructors for the map
entry types, and providing appropriate comparison overloads so that we
can search for map entries without constructing a dummy entry. While
doing that, I took the opportunity to modernize the code, and add some
tests. Functions that were completely unused are deleted.

This required also some changes in the Symtab code, as it was default
constructing map entries, which was not impossible even though its
value type was default-constructible. Technically, these changes could
be avoided with some SFINAE on the entry type, but I felt that the code
is cleaner this way anyway.

Reviewers: JDevlieghere, sgraenitz

Subscribers: mgorny, aprantl, lldb-commits

Differential Revision: https://reviews.llvm.org/D63268

llvm-svn: 363357
2019-06-14 06:33:31 +00:00
..
cmake [CMake] Fix generated Xcode-project ignoring output directory setting for LLDB.framework 2019-06-13 17:35:50 +00:00
docs [Docs] Modernize references to macOS 2019-05-30 16:46:22 +00:00
examples [lldb] Ignore null frames in lldb.macosx crashlog 2019-06-12 14:46:37 +00:00
include/lldb Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups 2019-06-14 06:33:31 +00:00
lit DWARF: Don't create lldb CompileUnits for DWARF type units 2019-06-13 11:22:47 +00:00
lldb.xcodeproj Update AuxVector.cpp 2019-06-11 21:20:34 +00:00
lldb.xcworkspace Remove accidentally commited file in xcshareddata 2019-02-05 23:35:01 +00:00
packages/Python/lldbsuite Skip failing test on older versions of clang. 2019-06-12 21:30:00 +00:00
resources [CMake] Revised LLDB.framework builds 2019-01-04 12:46:50 +00:00
scripts Make SBDebugger.RunCommandInterpreter callable from Python. 2019-05-15 00:08:55 +00:00
source Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups 2019-06-14 06:33:31 +00:00
test [CMake] Folder structure for generated Xcode project to cover more targets 2019-05-28 09:29:05 +00:00
third_party/Python/module [lldb/thirdparty] Remove unneeded files, asked by Jonas. 2019-03-12 20:41:36 +00:00
tools [CMake] Two extra FOLDER properties for debugserver 2019-06-12 14:46:30 +00:00
unittests Make UniqueCStringMap work with non-default-constructible types and other improvements/cleanups 2019-06-14 06:33:31 +00:00
utils [CMake] Fix lldb-dotest for single-config generators in standalone builds 2019-06-13 17:35:43 +00:00
.arcconfig
.clang-format
.gitignore Add .noindex to the gitignore 2019-04-05 17:57:42 +00:00
CMakeLists.txt [CMake] LLDB.framework tools handling 2019-05-29 11:26:06 +00:00
CODE_OWNERS.txt Fix/unify the spelling of Objective-C. 2018-06-13 16:21:24 +00:00
INSTALL.txt Fix build URL in new LLDB website 2019-05-01 09:55:00 +00:00
LICENSE.TXT Fix typos throughout the license files that somehow I and my reviewers 2019-01-21 09:52:34 +00:00
use_lldb_suite_root.py