llvm-project/libcxx
Hui Xie 20869c5ba0 [libc++] fix views::all hard error on lvalue move only views instead of SFINAE
For an lvalue reference to a move only view x, views::all(x) gives hard error because the expression inside noexcept is not well formed and it is not SFINAE friendly.

Given a move only view type `V`, and a concept

```
template <class R>
concept can_all = requires {
    std::views::all(std::declval<R>());
};
```

The expression `can_all<V&>` returns
libstdc++: false
msvc stl : false
libc++   : error: static_cast from 'V' to 'typename decay<decltype((std::forward<V &>(__t)))>::type' (aka 'V') uses deleted function
      noexcept(noexcept(_LIBCPP_AUTO_CAST(std::forward<_Tp>(__t))))

The standard spec has its own problem, the spec says it is expression equivalent to `decay-copy(E)` but the spec of `decay-copy` does not have any constraint, which means the expression `decay-copy(declval<V&>())` is well-formed and the concept `can_all<V&>` should return true and should error when instantiating the function body of decay-copy. This is clearly wrong behaviour in the spec and we will probably create an LWG issue. But the libc++'s behaviour is clearly not correct. The `noexcept` is an "extension" in libc++ which is not in the spec, but the expression inside `noexpect` triggers hard error, which is not right.

Reviewed By: #libc, ldionne, var-const

Differential Revision: https://reviews.llvm.org/D128281
2022-06-22 09:50:16 +01:00
..
benchmarks [libc++] Don't force -O2 when building the benchmarks 2022-06-17 17:34:02 -04:00
cmake [libcxx][AIX] Switch build compiler to clang 2022-06-13 21:45:18 -04:00
docs [libc++] Complete the implementation of N4190 2022-06-22 10:13:03 +02:00
include [libc++] fix views::all hard error on lvalue move only views instead of SFINAE 2022-06-22 09:50:16 +01:00
lib [libcxx][AIX] Enable ABI list checking for XCOFF 2022-06-14 13:16:00 -04:00
src [libc++] Improve charconv base10 algorithm. 2022-06-21 17:45:40 +02:00
test [libc++] fix views::all hard error on lvalue move only views instead of SFINAE 2022-06-22 09:50:16 +01:00
utils [libc++][CI] Updates GCC to version 12. 2022-06-21 18:59:20 +02:00
.clang-format [libcxx] Remove extraneous '---' lines in .clang-format files 2022-06-15 01:34:37 -07:00
.clang-tidy [libc++][clang-tidy] Enable bugprone-use-after-move and explicitly list all used checks 2022-06-21 20:25:04 +02:00
.gitignore
CMakeLists.txt [libcxx][AIX] Switch build compiler to clang 2022-06-13 21:45:18 -04:00
CREDITS.TXT Microsoft's floating-point to_chars powered by Ryu and Ryu Printf 2021-12-12 16:34:50 +01:00
LICENSE.TXT
TODO.TXT [libc++] Disallow volatile types in std::allocator 2021-09-22 11:47:38 -04:00
appveyor-reqs-install.cmd
appveyor.yml