llvm-project/clang
Graydon Hoare e0a68355f2 [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces.
Summary:
In change 2ba19793512, the ASTReader logic for ObjC interfaces was modified to
preserve the first definition-data read, "merging" later definitions into it
rather than overwriting it (though this "merging" is, in practice, a no-op that
discards the later definition-data).

Unfortunately this change was only made to ObjC interfaces, not protocols; this
means that when (for example) loading a protocol that references an interface,
if both the protocol and interface are multiply defined (as can easily happen
if the same header is read from multiple contexts), an _inconsistent_ pair of
definitions is loaded: first-read for the interface and last-read for the
protocol.

This in turn causes very subtle downstream bugs in the Swift ClangImporter,
which filters the results of name lookups based on the owning module of a
definition; inconsistency between a pair of related definitions causes name
lookup failures at various stages of compilation.

To fix these downstream issues, this change replicates the logic applied to
interfaces in change 2ba19793512, but for ObjC protocols.

rdar://30851899

Reviewers: doug.gregor, rsmith

Reviewed By: doug.gregor

Subscribers: jordan_rose, cfe-commits

Differential Revision: https://reviews.llvm.org/D34741

llvm-svn: 306583
2017-06-28 18:36:27 +00:00
..
INPUTS
bindings [libclang] Support for querying the exception specification type through libclang 2017-06-27 22:54:56 +00:00
cmake Don't defer to the GCC driver for linking arm-baremetal 2017-05-25 15:42:13 +00:00
docs clang-format - Also reference the list of style option of clang-format in Libformat 2017-06-26 03:19:05 +00:00
examples Add LLVMOption to clang-interpreter, corresponding to r291938. 2017-01-14 08:54:05 +00:00
include [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces. 2017-06-28 18:36:27 +00:00
lib [ASTReader] Treat multiple defns of ObjC protocols the same as interfaces. 2017-06-28 18:36:27 +00:00
runtime [sanitizer] Passthrough CMAKE_OSX_DEPLOYMENT_TARGET and CMAKE_OSX_SYSROOT when building compiler-rt from clang/runtime/CMakeLists.txt 2016-12-15 23:20:54 +00:00
test Fix crash in clang while handling __has_trivial_destructor. 2017-06-28 08:52:08 +00:00
tools [libclang] Support for querying the exception specification type through libclang 2017-06-27 22:54:56 +00:00
unittests [clang-format] Support <>-style proto message fields 2017-06-27 13:43:07 +00:00
utils [Bash-autocompletion] Invoke clang where user called 2017-06-28 16:29:26 +00:00
www [coroutines] www/cxx_status.html: add non-breaking hyphen 2017-05-28 17:35:23 +00:00
.arcconfig
.clang-format
.clang-tidy
.gitignore
CMakeLists.txt [GSoC] Shell autocompletion for clang 2017-05-23 18:39:08 +00:00
CODE_OWNERS.TXT
INSTALL.txt
LICENSE.TXT
ModuleInfo.txt
NOTES.txt
README.txt

README.txt

//===----------------------------------------------------------------------===//
// C Language Family Front-end
//===----------------------------------------------------------------------===//

Welcome to Clang.  This is a compiler front-end for the C family of languages
(C, C++, Objective-C, and Objective-C++) which is built as part of the LLVM
compiler infrastructure project.

Unlike many other compiler frontends, Clang is useful for a number of things
beyond just compiling code: we intend for Clang to be host to a number of
different source-level tools.  One example of this is the Clang Static Analyzer.

If you're interested in more (including how to build Clang) it is best to read
the relevant web sites.  Here are some pointers:

Information on Clang:              http://clang.llvm.org/
Building and using Clang:          http://clang.llvm.org/get_started.html
Clang Static Analyzer:             http://clang-analyzer.llvm.org/
Information on the LLVM project:   http://llvm.org/

If you have questions or comments about Clang, a great place to discuss them is
on the Clang development mailing list:
  http://lists.llvm.org/mailman/listinfo/cfe-dev

If you find a bug in Clang, please file it in the LLVM bug tracker:
  http://llvm.org/bugs/