forked from OSchip/llvm-project
7bdad08429
This patch contains the basic functionality for reporting potentially incorrect usage of __builtin_expect() by comparing the developer's annotation against a collected PGO profile. A more detailed proposal and discussion appears on the CFE-dev mailing list (http://lists.llvm.org/pipermail/cfe-dev/2019-July/062971.html) and a prototype of the initial frontend changes appear here in D65300 We revised the work in D65300 by moving the misexpect check into the LLVM backend, and adding support for IR and sampling based profiles, in addition to frontend instrumentation. We add new misexpect metadata tags to those instructions directly influenced by the llvm.expect intrinsic (branch, switch, and select) when lowering the intrinsics. The misexpect metadata contains information about the expected target of the intrinsic so that we can check against the correct PGO counter when emitting diagnostics, and the compiler's values for the LikelyBranchWeight and UnlikelyBranchWeight. We use these branch weight values to determine when to emit the diagnostic to the user. A future patch should address the comment at the top of LowerExpectIntrisic.cpp to hoist the LikelyBranchWeight and UnlikelyBranchWeight values into a shared space that can be accessed outside of the LowerExpectIntrinsic pass. Once that is done, the misexpect metadata can be updated to be smaller. In the long term, it is possible to reconstruct portions of the misexpect metadata from the existing profile data. However, we have avoided this to keep the code simple, and because some kind of metadata tag will be required to identify which branch/switch/select instructions are influenced by the use of llvm.expect Patch By: paulkirth Differential Revision: https://reviews.llvm.org/D66324 llvm-svn: 371635 |
||
|---|---|---|
| .. | ||
| c-attributes.proftext | ||
| c-captured.proftext | ||
| c-counter-overflows.proftext | ||
| c-general.profdata.v1 | ||
| c-general.profdata.v3 | ||
| c-general.proftext | ||
| c-outdated-data.proftext | ||
| c-unprofiled-blocks.proftext | ||
| c-unprofiled.proftext | ||
| cxx-class.proftext | ||
| cxx-hash-v2.profdata.v5 | ||
| cxx-hash-v2.proftext | ||
| cxx-lambda.proftext | ||
| cxx-missing-bodies.proftext | ||
| cxx-rangefor.proftext | ||
| cxx-templates.proftext | ||
| cxx-throws.proftext | ||
| func-entry.proftext | ||
| gcc-flag-compatibility.proftext | ||
| gcc-flag-compatibility_IR.proftext | ||
| max-function-count.proftext | ||
| misexpect-branch-nonconst-expect-arg.proftext | ||
| misexpect-branch.proftext | ||
| misexpect-switch-default-only.proftext | ||
| misexpect-switch-default.proftext | ||
| misexpect-switch-nonconst.proftext | ||
| misexpect-switch.proftext | ||
| objc-general.proftext | ||
| profile-summary.proftext | ||
| profiled_header.h | ||