llvm-project/lldb/source/Plugins
Greg Clayton 274060b6f1 Fixed an issue where we were resolving paths when we should have been.
So the issue here was that we have lldb_private::FileSpec that by default was 
always resolving a path when using the:

FileSpec::FileSpec (const char *path);

and in the:

void FileSpec::SetFile(const char *pathname, bool resolve = true);

This isn't what we want in many many cases. One example is you have "/tmp" on
your file system which is really "/private/tmp". You compile code in that
directory and end up with debug info that mentions "/tmp/file.c". Then you 
type:

(lldb) breakpoint set --file file.c --line 5

If your current working directory is "/tmp", then "file.c" would be turned 
into "/private/tmp/file.c" which won't match anything in the debug info.
Also, it should have been just a FileSpec with no directory and a filename
of "file.c" which could (and should) potentially match any instances of "file.c"
in the debug info.

So I removed the constructor that just takes a path:

FileSpec::FileSpec (const char *path); // REMOVED

You must now use the other constructor that has a "bool resolve" parameter that you must always supply:

FileSpec::FileSpec (const char *path, bool resolve);

I also removed the default parameter to SetFile():

void FileSpec::SetFile(const char *pathname, bool resolve);

And fixed all of the code to use the right settings.

llvm-svn: 116944
2010-10-20 20:54:39 +00:00
..
ABI Added extra logging, and made sure that the argument 2010-10-08 01:58:41 +00:00
Disassembler/llvm Added the ability to get the disassembly instructions from the function and 2010-10-06 03:09:58 +00:00
DynamicLoader/MacOSX-DYLD Fixed an issue where we were resolving paths when we should have been. 2010-10-20 20:54:39 +00:00
LanguageRuntime Use the ValueObject directly where possible. 2010-10-15 22:53:49 +00:00
ObjectContainer Add UserSettings to Target class, making Target settings 2010-09-20 20:44:43 +00:00
ObjectFile Fixed an issue where we were resolving paths when we should have been. 2010-10-20 20:54:39 +00:00
Process Fixed an issue where we were resolving paths when we should have been. 2010-10-20 20:54:39 +00:00
SymbolFile Fixed an issue where we were resolving paths when we should have been. 2010-10-20 20:54:39 +00:00
SymbolVendor/MacOSX Change over to using the definitions for mach-o types and defines to the 2010-07-21 22:12:05 +00:00
Makefile Fix makefiles to build properly on Darwin. 2010-07-24 04:10:59 +00:00